Dotfiles

Dotfiles

Verdict: READY

Re-review of board item #358 after scope refinement (comment on forgejo_admin/dotfiles#1). Previous review review-358-2026-03-25 returned NEEDS_REFINEMENT citing missing File Targets and Constraints. Both have been addressed.

Template Completeness

• [x] Lineage -- present: "standalone -- discovered during tmux daily use"
• [x] Repo -- present: ldraney/tmux-custom (GitHub)
• [ ] User Story -- MISSING (acceptable omission for bug type)
• [x] Context -- present as "What Broke" + "Repro Steps" + "Expected Behavior" (thorough for a bug)
• [x] File Targets -- NOW PRESENT (refinement comment): ~/tmux-custom/.tmux.conf, after line 95
• [x] Acceptance Criteria -- present (4 criteria, all verifiable)
• [ ] Test Expectations -- MISSING (mitigated: tmux configs lack automated test harness)
• [x] Constraints -- NOW PRESENT (refinement comment): TPM load order, post-TPM block at line 98
• [ ] Checklist -- MISSING (minor: agent knows to open PR)
• [x] Related -- present

File Targets

• [x] ~/tmux-custom/.tmux.conf -- verified exists, 102 lines
• [x] Line 95: run '~/.tmux/plugins/tpm/tpm' -- verified exact match
• [x] Line 98: set -g automatic-rename off -- verified exact match (post-TPM block start)
• [x] Line 72: set -g renumber-windows on -- verified exact match (referenced in acceptance criteria)
• [x] ~/.tmux/plugins/tmux-pain-control/pain_control.tmux lines 30-31 -- verified swap-window -d -t -1 and swap-window -d -t +1 on < and >
• [x] Refinement correctly states DO NOT modify plugin file -- override via config only

Repo Placement

OK. Issue filed on forgejo_admin/dotfiles (issue tracker). Code lives in ldraney/tmux-custom (GitHub). Single repo affected. Split is documented.

Dependencies

None. Board item #358 is the only item on board-dotfiles. No blockers, no blocked items. Standalone bug fix.

Acceptance Criteria

4 criteria provided, all manually verifiable with clear pass/fail:

• [x] prefix + < moves current window left without displacing non-adjacent windows
• [x] prefix + > moves current window right without displacing non-adjacent windows
• [x] Repeatable (-r) -- implies bind-key -r flag
• [x] Works with renumber-windows on (line 72 verified)

Blast Radius

• Only other swap-window in config: line 17 (MouseDrag1Status swap-window -dt=) -- mouse drag reorder, unaffected by </> override
• No other swap-window or move-window bindings anywhere in the tmux-custom repo
• Plugin also sets pane nav (h/j/k/l), pane resize (H/J/K/L), split bindings -- all unaffected
• No downstream consumers. Self-contained dotfile change.

Refinement Delta

What changed since review-358-2026-03-25:

• File Targets added: ~/tmux-custom/.tmux.conf after line 95. Verified accurate.
• Constraints added: TPM load order documented. Post-TPM block (line 98) identified as insertion zone. Verified accurate.
• Both additions match the previous review's recommendations exactly.

Recommendation

No action needed. Ticket is agent-executable. The issue body plus refinement comment together form a complete spec. An agent reading the issue and its comments has everything needed: file path, insertion point, load-order constraint, acceptance criteria, and blast radius awareness.

Verdict: NEEDS_REFINEMENT

Template Completeness

• [x] Lineage -- present: "standalone -- discovered during tmux daily use"
• [x] Repo -- present: ldraney/tmux-custom (GitHub)
• [ ] User Story -- MISSING (acceptable omission for bug type)
• [x] Context -- present as "What Broke" + "Repro Steps" + "Expected Behavior" (thorough for a bug)
• [ ] File Targets -- MISSING. Agent needs explicit file path and modification zone.
• [x] Acceptance Criteria -- present (4 criteria)
• [ ] Test Expectations -- MISSING (mitigated: tmux configs lack automated test harness)
• [ ] Constraints -- MISSING. Critical: plugin load order not documented.
• [ ] Checklist -- MISSING
• [x] Related -- present

File Targets

• [x] ~/tmux-custom/.tmux.conf -- verified exists (symlinked from ~/.tmux.conf). 102 lines. Config confirmed.
• [x] renumber-windows on at line 72 -- verified exactly as claimed.
• [x] ~/.tmux/plugins/tmux-pain-control/pain_control.tmux -- verified. Lines 29-32 confirm swap-window -d -t -1 and swap-window -d -t +1 bindings on < and >.
• [ ] ISSUE: No File Targets section in the issue. The agent must know to add override bindings to ~/tmux-custom/.tmux.conf, specifically AFTER the TPM init line (line 95: run '~/.tmux/plugins/tpm/tpm'). This is not stated anywhere.

Repo Placement

OK. Issue filed on forgejo_admin/dotfiles (issue tracker). Code lives in ldraney/tmux-custom (GitHub). Repo description confirms this split: "Code lives on GitHub (tmux-custom), issues tracked here." Single repo affected.

Dependencies

No dependencies. Board item #358 is the only item on board-dotfiles. No blockers, no blocked items. Standalone bug fix.

Acceptance Criteria

4 criteria provided. Assessment:

• [x] "prefix + < moves current window left one position without displacing non-adjacent windows" -- testable manually, clear pass/fail
• [x] "prefix + > moves current window right one position without displacing non-adjacent windows" -- testable manually, clear pass/fail
• [x] "Repeatable (-r) -- mash key to slide through multiple positions" -- testable, implies bind-key -r flag
• [x] "Works with renumber-windows on (line 72 in config)" -- testable, line reference verified accurate

Criteria are well-written and verifiable. No missing criteria detected.

Blast Radius

• The only other swap-window binding in the config is line 17: bind-key -n MouseDrag1Status swap-window -dt= (mouse drag reorder). The fix should NOT change this -- it only overrides the < / > keybindings from tmux-pain-control.
• The plugin also sets pane navigation (h/j/k/l), pane resize (H/J/K/L), split bindings (|, -, etc.), and new-window. These are unaffected by overriding only < / >.
• No sibling services or downstream consumers. Self-contained dotfile change.

Recommendation

Two issues must be addressed before this ticket is READY:

1. Add File Targets section:

   ### File Targets
   - `~/tmux-custom/.tmux.conf` -- add override bindings AFTER TPM init (after line 95)
   - DO NOT modify `~/.tmux/plugins/tmux-pain-control/pain_control.tmux` -- plugin-managed file

2. Add Constraints section:

   ### Constraints
   - Override bindings MUST be placed after `run '~/.tmux/plugins/tpm/tpm'` (line 95). TPM executes plugin scripts during init, so any binding set before this line will be overwritten by tmux-pain-control.
   - Use `swap-window` with adjacent target only (not move-window, which has different renumber semantics).
   - Keep `-r` flag for repeat capability.
   - Do NOT touch the MouseDrag1Status binding on line 17 (separate feature).