pal-e-docs

Review: tmux window move should insert, not swap (re-review)

review-358-2026-03-25-v2 Review

review ready
Project

Verdict: READY

Re-review of board item #358 after scope refinement (comment on forgejo_admin/dotfiles#1). Previous review review-358-2026-03-25 returned NEEDS_REFINEMENT citing missing File Targets and Constraints. Both have been addressed.

Template Completeness

  • [x] Lineage -- present: "standalone -- discovered during tmux daily use"
  • [x] Repo -- present: ldraney/tmux-custom (GitHub)
  • [ ] User Story -- MISSING (acceptable omission for bug type)
  • [x] Context -- present as "What Broke" + "Repro Steps" + "Expected Behavior" (thorough for a bug)
  • [x] File Targets -- NOW PRESENT (refinement comment): ~/tmux-custom/.tmux.conf, after line 95
  • [x] Acceptance Criteria -- present (4 criteria, all verifiable)
  • [ ] Test Expectations -- MISSING (mitigated: tmux configs lack automated test harness)
  • [x] Constraints -- NOW PRESENT (refinement comment): TPM load order, post-TPM block at line 98
  • [ ] Checklist -- MISSING (minor: agent knows to open PR)
  • [x] Related -- present

File Targets

  • [x] ~/tmux-custom/.tmux.conf -- verified exists, 102 lines
  • [x] Line 95: run '~/.tmux/plugins/tpm/tpm' -- verified exact match
  • [x] Line 98: set -g automatic-rename off -- verified exact match (post-TPM block start)
  • [x] Line 72: set -g renumber-windows on -- verified exact match (referenced in acceptance criteria)
  • [x] ~/.tmux/plugins/tmux-pain-control/pain_control.tmux lines 30-31 -- verified swap-window -d -t -1 and swap-window -d -t +1 on < and >
  • [x] Refinement correctly states DO NOT modify plugin file -- override via config only

Repo Placement

OK. Issue filed on forgejo_admin/dotfiles (issue tracker). Code lives in ldraney/tmux-custom (GitHub). Single repo affected. Split is documented.

Dependencies

None. Board item #358 is the only item on board-dotfiles. No blockers, no blocked items. Standalone bug fix.

Acceptance Criteria

4 criteria provided, all manually verifiable with clear pass/fail:
  • [x] prefix + < moves current window left without displacing non-adjacent windows
  • [x] prefix + > moves current window right without displacing non-adjacent windows
  • [x] Repeatable (-r) -- implies bind-key -r flag
  • [x] Works with renumber-windows on (line 72 verified)

Blast Radius

  • Only other swap-window in config: line 17 (MouseDrag1Status swap-window -dt=) -- mouse drag reorder, unaffected by </> override
  • No other swap-window or move-window bindings anywhere in the tmux-custom repo
  • Plugin also sets pane nav (h/j/k/l), pane resize (H/J/K/L), split bindings -- all unaffected
  • No downstream consumers. Self-contained dotfile change.

Refinement Delta

What changed since review-358-2026-03-25:
  • File Targets added: ~/tmux-custom/.tmux.conf after line 95. Verified accurate.
  • Constraints added: TPM load order documented. Post-TPM block (line 98) identified as insertion zone. Verified accurate.
  • Both additions match the previous review's recommendations exactly.

Recommendation

No action needed. Ticket is agent-executable. The issue body plus refinement comment together form a complete spec. An agent reading the issue and its comments has everything needed: file path, insertion point, load-order constraint, acceptance criteria, and blast radius awareness.