Validation: basketball-api #475 ruff format fix

Validation: basketball-api #475 ruff format fix

Verdict

PASS — 2026-04-13 22:07 UTC

Ticket

• Issue: forgejo_admin/basketball-api#475
• PR: forgejo_admin/basketball-api#476 (merged, squash commit on main)
• Deploy commit: 44aef6d

Evidence

1. Push pipeline triggered: Woodpecker #487 ran on push to main (prior push pipelines were failing silently on ruff format check).
2. ruff format check would pass: pre-merge local check on branch confirmed ruff format --check . output: "120 files already formatted, 1 reformatted". Post-merge file tests/test_players.py now matches ruff canonical format.
3. Pipeline #487 test step failure is NOT ruff-related: Failures are test_send_first_payment_email (subject string mismatch) and test_migration_file_exists (missing migration 041). Pre-existing on main.
4. Deploy unblocked: build-and-push and update-kustomize-tag both ran successfully in pipeline #487, proving the deploy path is functional. New image 44aef6d deployed to prod.

Notes

This fix was a prerequisite for validating #473. Without it, push pipelines were failing but still completing the deploy — confusing the validation pipeline. It also unblocks clean deploys going forward.

Pre-existing test failures on main remain: test_send_first_payment_email and test_migration_file_exists. These need separate tickets.