Validation: Remove gh CLI references (#268)
Ticket
#268 — Remove gh CLI references, fix post-merge hook for Forgejo MCP merges. PR #269 merged via squash.
Environment
Local repo at
~/claude-custom, verified on main branch post-merge.Checks
| # | Criterion | How to Verify | Result | Evidence |
|---|---|---|---|---|
| 1 | 4 dead hooks deleted | <code>ls hooks/block-pr-merge.sh ...</code> | PASS | All 4 files absent from working tree |
| 2 | No gh permissions in settings | <code>grep "Bash(gh " settings*.json</code> | PASS | 0 matches in both files |
| 3 | check-issue.sh Forgejo-only | <code>grep "gh issue" hooks/check-issue.sh</code> | PASS | No gh CLI calls remain |
| 4 | All hooks pass syntax check | <code>bash -n hooks/*.sh</code> | PASS | No errors |
| 5 | MCP hooks untouched | <code>git diff HEAD hooks/post-mcp-merge-rebase.sh</code> | PASS | No changes to MCP replacement hooks |
Verdict
PASS — all checks green. 327 lines deleted, 19 added.
Discovered Issues
hooks/pypi-pr-checklist.sh is now effectively dead code — its trigger (gh pr create) will never fire. Needs follow-up ticket to delete or convert to MCP trigger.