pal-e-docs

Skill: Review PR

skill-review-pr Skill

active skill
Project

Skill: Review PR

QA Agent workflow. Reviews a PR diff for code quality, correctness, security, and SOP compliance. Posts structured findings as a PR comment.

Steps

  • Read the plan — mcp__pal-e-docs__get_note(slug="<plan-slug>"). Understand what the phase was supposed to accomplish.
  • Read the project page — mcp__pal-e-docs__get_note(slug="project-<project-slug>"). Understand architecture and conventions.
  • Read SOPs — mcp__pal-e-docs__get_note(slug="pr-review-loop"), mcp__pal-e-docs__get_note(slug="template-pr-body"). Know what to check.
  • Get the PR diff — mcp__forgejo__review_pr(owner="forgejo_admin", repo="<repo>", pr_number=N). Read the full diff.
  • Review for correctness — Does the code work? Are there bugs, edge cases, security issues? Do tests cover the changes?
  • Review for SOP compliance — Run the checklist:
  • Post findings — mcp__forgejo__comment_on_pr(owner="forgejo_admin", repo="<repo>", pr_number=N, body="<review>"). Use the structured format below.
  • Report and stop — Return the verdict to the user. Do not fix code. Do not merge.

Review Comment Format

IMPORTANT: The VERDICT line must use the exact format shown below. PostToolUse hooks parse this line to automatically set Forgejo labels (status:approved or status:needs-fix) on the parent issue. Do not deviate from this format.
Or if not approved:
The VERDICT line must be exactly ### VERDICT: APPROVED or ### VERDICT: NOT APPROVED — no variations, no extra text on the line. Hooks match ^### VERDICT: APPROVED$ and ^### VERDICT: NOT APPROVED$ with exact case.

MCP Tools

Step Tool Purpose
1 <code>mcp__pal-e-docs__get_note</code> Read plan note
2 <code>mcp__pal-e-docs__get_note</code> Read project page
3 <code>mcp__pal-e-docs__get_note</code> Read SOPs, PR template
3 <code>mcp__pal-e-docs__list_notes</code> Discover relevant conventions
4 <code>mcp__forgejo__review_pr</code> Get PR diff
7 <code>mcp__forgejo__comment_on_pr</code> Post review findings

Agent

agent-qa
  • skill-implement-phase — Dev Agent produces the PR this skill reviews
  • skill-fix-review — Dev Agent fixes findings from this review
  • pr-review-loop — the mandatory review-fix cycle
  • agent-qa — the agent that runs this skill
  • phase-2026-03-03-3-agent-configs — Phase 3 added the hook parsing requirement