Review: Fix split payment text — wrong amounts, wrong dates, wrong framing
Verdict: READY
Template Completeness
- [x] Type — present (Bug)
- [x] Lineage — present (plan-wkq → Phase 14)
- [x] Repo — present (forgejo_admin/westside-contracts)
- [x] What Broke — present, detailed with three numbered problems
- [x] Repro Steps — present
- [x] Expected Behavior — present with proposed replacement text
- [x] Environment — present (prod / westside-contracts, commit d1a6cbe)
- [x] Acceptance Criteria — present (5 items, all verifiable)
- [ ] File Targets — partial: says "Lines 319 and 377 of +page.svelte" but omits the full path
src/routes/contract/[token]/+page.svelte. Line numbers are accurate. - [ ] Test Expectations — missing (no test commands specified). Minor for a text-only fix.
- [ ] Constraints — missing. Minor for a text-only fix.
- [x] Related — present (project-westside-basketball)
File Targets
- [x]
src/routes/contract/[token]/+page.svelteline 319 — verified: was "Split payments available: $100 on the 15th, $100 on the 30th." Now updated to opt-in language with 1st/15th dates. - [x]
src/routes/contract/[token]/+page.svelteline 377 — verified: same pattern, same fix applied. - [x] No hardcoded dollar amounts remain in the split payment text.
- [x] The $100 at line 209 is a gas cost in a trip expense table — unrelated to this bug.
Repo Placement
OK. Issue filed on forgejo_admin/westside-contracts, fix is in westside-contracts. Single-repo change. No cross-repo impact.
Dependencies
- No blockers. This is an independent text fix.
- Phase 14 (Billing Tiers & Contracts) is in_progress on the board.
- E2E walkthrough (westside-contracts #7) in next_up would benefit from this being merged first, but does not explicitly depend on it.
- Related done items: #6 (outbox event), #9 (timezone), #11 (mobile date), bball-api #160 (fee verification) — all resolved, no conflicts.
Acceptance Criteria
All 5 criteria are verifiable by an agent:
- [x] "Split payment text updated on both travel (line 319) and local (line 377) variants" — grep-verifiable
- [x] "No hardcoded dollar amounts in the split payment text" — grep-verifiable
- [x] "Dates changed from 15th/30th to 1st/15th" — grep-verifiable
- [x] "Framed as opt-in (reach out to us) not default" — grep-verifiable
- [x] "Build passes, tests pass" — CI-verifiable
Blast Radius
None. Searched westside-app and basketball-api for similar split payment / hardcoded amount patterns — no matches. The problematic text existed only in westside-contracts.
Implementation Status
Fix already implemented: commit
bbd13e3 on branch 15-fix-split-payment-text, pushed to origin. PR #16 is open against main. Not yet merged.Recommendation
No action needed on scope. Issue is well-specified and fix is already in flight (PR #16). Two minor template gaps (incomplete file path, missing Test Expectations section) are immaterial for a 2-line text change. Merge PR #16 to close.