pal-e-docs

Review: infra: rename pal-e-production to pal-e-app across all layers

review-989-2026-04-12 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- Standalone with consolidated bug refs
  • [x] Repo -- Multi-repo identified
  • [x] User Story -- present
  • [x] Context -- thorough, explains 5-layer cascade
  • [x] File Targets -- extensive, with "do not touch" list
  • [x] Acceptance Criteria -- 11 items
  • [x] Test Expectations -- 5 items with commands
  • [x] Constraints -- 7 items, blue-green strategy documented
  • [x] Checklist -- 10 items
  • [x] Related -- cross-references present
All required sections for Feature template are present and well-populated.

Traceability

  • [x] story:app-definition label -- present on board item
  • [ ] story note MISSING -- No "app-definition" story found in project-pal-e-app user-stories section. Stories there are PA-S1 through PA-S5. [SCOPE] Create user story entry "app-definition" on project-pal-e-app user-stories section, or re-label to match an existing story key.
  • [x] arch:pal-e-app label -- present on board item
  • [ ] arch note MISSING -- search for "arch-pal-e-app" returned no results. [SCOPE] Create architecture note arch-pal-e-app for the pal-e-app component.
  • [x] Forgejo issue -- forgejo_admin/pal-e-deployments#114, open
  • [ ] definition-app note referenced in issue body does not exist in pal-e-docs (search returned empty). [BODY] Verify or create definition-app note.

File Targets

  • [x] pal-e-services/terraform/k3s.tfvars -- verified: contains pal-e-production service key at line 202
  • [x] pal-e-deployments/overlays/pal-e-production/prod/ -- verified: 4 files exist (kustomization.yaml, ingress.yaml, deployment-patch.yaml, harbor-creds.enc.yaml)
  • [x] pal-e-deployments/overlays/pal-e-docs/prod/kustomization.yaml -- verified: lines 54, 71 contain commented pal-e-production cross-namespace refs
  • [x] pal-e-platform/terraform/modules/monitoring/main.tf lines 386-388 -- verified: blackbox probe name/url/labels for pal-e-production
  • [x] pal-e-platform/terraform/modules/monitoring/main.tf lines 649-661 -- verified: golden signals dashboard ConfigMap
  • [x] pal-e-platform/terraform/modules/monitoring/main.tf lines 730-741 -- verified: embedding worker ServiceMonitor with pal-e-production namespace
  • [x] pal-e-platform/terraform/dashboards/pal-e-production-golden-signals.json -- verified: exists, 14 occurrences of pal-e-production
  • [x] pal-e-platform/terraform/modules/ops/main.tf lines 109-125 -- verified: embedding worker metrics service in pal-e-production namespace
  • [x] pal-e-platform/terraform/modules/ops/variables.tf line 2 -- verified: variable description references pal-e-production
  • [x] pal-e-platform/terraform/modules/database/main.tf lines 59-67 -- verified: namespace data source + postgres secret
  • [x] pal-e-platform/terraform/modules/database/outputs.tf line 12 -- verified: output description
  • [x] pal-e-platform/terraform/network-policies.tf lines 172, 196 -- verified: cross-namespace allow rules
  • [x] pal-e-platform/terraform/secrets.auto.tfvars.example line 35 -- verified: secrets comment
All 13 file targets verified. Line numbers are accurate.

Repo Placement

Issue is filed on pal-e-deployments but touches 3 repos (pal-e-services, pal-e-deployments, pal-e-platform) plus the Forgejo repo rename. This is correctly identified in the issue body. Multi-repo coordination is acknowledged.

Dependencies

  • Board items #714 (pal-e-platform#257 "Namespace rename pal-e-docs-app to pal-e-app") and #712 (pal-e-platform#255 "Keycloak client rename") are related naming work -- potential ordering dependency not documented.
  • Board items #979 and #980 are filed against pal-e-production repo -- these will need URL updates after repo rename.
  • Board items #716, #717 reference pal-e-production issues -- Forgejo issue URLs on these board items will break after repo rename.
  • Consolidated bugs (#99, pal-e-deployments#97, #81) are listed as related but dependency ordering is clear (this ticket resolves them).

Acceptance Criteria

11 acceptance criteria. Most are verifiable by an agent (kubectl, curl, grep, tofu plan). The criteria are clear and testable. However, 11 AC across 3 repos plus a Forgejo admin API call is too many for a single agent pass.

Blast Radius

  • Grep confirms 34 occurrences of "pal-e-production" in pal-e-platform/terraform/ and 16 in pal-e-deployments. The ticket's "60+ references" claim is roughly correct when including the dashboard JSON (14 alone).
  • Existing board items referencing pal-e-production Forgejo URLs (#979, #980, #716, #717) will have broken issue links after rename. These need updating.
  • monitoring/main.tf already has BOTH a pal-e-production probe (line 386) AND a pal-e-app probe (line 391) -- the new probe exists, so the rename is partially in progress. Ticket should note this to avoid creating a duplicate.
  • The embedding worker references (ops/main.tf, monitoring/main.tf) use a var.pal_e_production_namespace variable -- renaming this variable cascades through the module call in the root module. Ticket should document this terraform variable rename.

Decomposition Assessment

NEEDS DECOMPOSITION. This ticket fails the 5-minute rule on all dimensions:
  • 13+ file targets across 3 repos (threshold: >3 files across >2 repos)
  • 11 acceptance criteria (threshold: >5)
  • Estimated agent work: 30+ minutes (blue-green across 3 repos with tofu apply steps)
  • Natural decomposition: (1) Forgejo repo rename, (2) pal-e-services terraform, (3) pal-e-deployments kustomize, (4) pal-e-platform monitoring/network-policies, (5) validation + old infra cleanup
Route to skill-decompose-ticket for sub-board creation.

Recommendation

  • [SCOPE] Create user story entry "app-definition" on project-pal-e-app user-stories section, or relabel board item to match an existing story key (PA-S1 through PA-S5).
  • [SCOPE] Create architecture note arch-pal-e-app for the pal-e-app component.
  • [BODY] Note that monitoring/main.tf already has a pal-e-app probe at line 391 -- ticket should clarify this is a remove-old, not add-new for that specific target.
  • [BODY] Document the terraform variable rename: var.pal_e_production_namespace must become var.pal_e_app_namespace (affects ops/variables.tf, database/main.tf, database/outputs.tf, and the root module call).
  • [BODY] Add note about board items (#979, #980, #716, #717) whose Forgejo issue URLs will break after repo rename -- these need URL updates.
  • [DECOMPOSE] 13 file targets across 3 repos, 11 AC, estimated 30+ min. Route to skill-decompose-ticket. Natural split: (1) Forgejo repo rename + Harbor re-tag, (2) pal-e-services terraform, (3) pal-e-deployments kustomize, (4) pal-e-platform terraform, (5) validation + cleanup.