Review: Rename westside-landing → westside-app (re-review)

Verdict: APPROVED

Template Completeness

• [x] Type — Feature
• [x] User Story — platform operator perspective, clear motivation
• [x] Lineage — story, arch, board references present
• [x] Repo — primary + also-touched repos identified
• [x] Context — explains half-renamed state and Lucas's naming distinction
• [x] File Targets — 5 files, 19 occurrences, all verified via grep
• [x] Acceptance Criteria — 8 items, all verifiable post-deploy
• [x] Test Expectations — kustomize build + kubectl + curl checks
• [ ] Constraints — absent as named section, but "Leave alone" table + "Secrets Note" serve the same purpose. Acceptable.
• [ ] Checklist — absent. Minor for infra rename.
• [ ] Related — absent. Minor.

Traceability

• [x] story:WS-S1 label — "As superadmin, I want to deploy platform changes via IaC so that infrastructure is reproducible and auditable"
• [x] story note verified — found in project-westside-basketball user-stories section under Superadmin
• [x] arch:westside-app label — references the authenticated SvelteKit frontend component
• [ ] arch note — no arch-westside-app note exists in pal-e-docs. Acceptable: this is a pure infra rename ticket, not architectural design work. The label correctly categorizes which component is affected.
• [x] Forgejo issue — forgejo_admin/westside-landing#208, state: open

File Targets

• [x] pal-e-deployments/overlays/westsidekingsandqueens/prod/kustomization.yaml — verified: 10 occurrences at lines 8, 17, 20, 23, 26, 37, 40, 43, 58, 61
• [x] pal-e-deployments/overlays/westsidekingsandqueens/prod/ingress.yaml — verified: 2 occurrences at lines 4, 11
• [x] pal-e-deployments/overlays/westsidekingsandqueens/prod/deployment-patch.yaml — verified: 4 occurrences at lines 16, 21, 26, 35
• [x] pal-e-deployments/overlays/westsidekingsandqueens/dev/deployment.yaml — verified: 1 occurrence at line 50
• [x] pal-e-platform/terraform/modules/monitoring/main.tf — verified: 2 occurrences at lines 401, 403

Repo Placement

Dependencies

• No blockers identified. Item #920 is in backlog, not blocked by any in-progress work.
• Related done items: #587-#590, #450 (the original landing rename decomposition, now reversed).
• Note: docs/superpowers/specs/2026-04-10-westside-admin-design.md contains 6 references to westside-landing — design doc, not infra. Not in scope for this rename but worth noting for future cleanup.

Acceptance Criteria

Blast Radius

• Keycloak client_id stays westside-landing — correctly excluded to avoid OIDC breakage.
• Secrets note identifies dual-secret situation (westside-app-auth + westside-landing-auth) and prescribes verification. Good.
• Woodpecker webhook is repo-ID-based per ticket — rename-safe. Verified in issue body.
• ArgoCD Application points to pal-e-deployments, not the app repo — unaffected. Verified in issue body.
• Harbor image repo uses westsidekingsandqueens/app — unaffected.

Decomposition Assessment

• pal-e-deployments PR: 4 files, 17 find-replace occurrences + kustomize build validation
• pal-e-platform PR: 1 file, 2 line changes + tofu validate
• Manual: Forgejo rename + local remote URL + secret verification

Refinement Resolution

• arch-westside-app note — accepted as label reference for infra rename (no arch design work)
• Duplicate board item #780 — removed from board
• Missing template sections — User Story, Lineage, Repo, Test Expectations all added
• Woodpecker webhook — clarified as repo-ID-based, rename-safe
• ArgoCD source — verified, points to pal-e-deployments, unaffected
• Decomposition — 2 PRs + 1 manual step breakdown added

Recommendation