pal-e-docs

Review: Rename westside-landing → westside-app (full: Forgejo + k8s + monitoring)

review-920-2026-04-12 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type — Feature
  • [x] Context — thorough explanation of naming mismatch
  • [x] Scope — excellent safe/leave-alone breakdown
  • [x] File Targets — 5 files across 2 repos, all verified
  • [x] Acceptance Criteria — 8 criteria
  • [x] Risks — ArgoCD churn, CI webhooks, open PRs
  • [x] Rollback — revert + rename back
  • [ ] User Story — missing as-a/I-want/so-that format
  • [ ] Lineage — missing (standalone or discovered scope?)
  • [ ] Repo — missing explicit repo header (work spans pal-e-deployments + pal-e-platform + Forgejo admin)
  • [ ] Test Expectations — missing (no test commands specified)
  • [ ] Constraints — missing
  • [ ] Checklist — missing

Traceability

  • [x] story:WS-S1 label — "As superadmin, I want to deploy platform changes via IaC so that infrastructure is reproducible and auditable"
  • [x] story note verified — found in project-westside-basketball user-stories section (Superadmin list)
  • [x] arch:westside-app label — present on board item
  • [ ] arch note MISSING — [SCOPE] Create architecture note arch-westside-app for component westside-app
  • [x] Forgejo issue — forgejo_admin/westside-landing#208, state: open

File Targets

  • [x] pal-e-deployments/overlays/westsidekingsandqueens/prod/kustomization.yaml — verified: 10 occurrences of "westside-landing" (ticket says ~10, accurate)
  • [x] pal-e-deployments/overlays/westsidekingsandqueens/prod/ingress.yaml — verified: 2 occurrences (resource name + service backend)
  • [x] pal-e-deployments/overlays/westsidekingsandqueens/prod/deployment-patch.yaml — verified: 4 occurrences (secret name refs)
  • [x] pal-e-deployments/overlays/westsidekingsandqueens/dev/deployment.yaml — verified: 1 occurrence (local path)
  • [x] pal-e-platform/terraform/modules/monitoring/main.tf — verified: 2 occurrences (probe name + labels)
Total: 19 occurrences across 5 files in 2 repos. All file paths exist and contain the claimed references.

Repo Placement

Issue is filed on forgejo_admin/westside-landing — this is correct because the Forgejo repo rename is the primary action. However, the work touches 3 distinct systems:
  • pal-e-deployments — k8s manifests (4 files, 17 occurrences)
  • pal-e-platform — monitoring terraform (1 file, 2 occurrences)
  • Forgejo admin UI — repo rename (manual or API)
The issue body correctly identifies all three but the Repo header is missing from the template. Multi-repo work is acknowledged in scope.

Dependencies

  • Duplicate board item #780 — "Rename westside-landing → westside-app" with identical labels (type:feature, arch:westside-app, story:WS-S1) sits in backlog. #920 supersedes #780. [SCOPE] Close or remove duplicate #780.
  • Board item #953 — "Add Vitest to westside-landing" references old name in title. Will need title update after this rename completes.
  • pal-e-services refs — keycloak.tf, keycloak-import.sh, services.tf all contain "westside-landing". Issue correctly marks these as "leave alone" (terraform state surgery). No blocker.
  • No in_progress blockers — none of the 8 in_progress items conflict with this rename.
  • Done items #587-#590 — the original landing rename (westside-app → westside-landing) is done. This ticket reverses it. No conflict.

Acceptance Criteria

8 criteria. All are verifiable via kubectl, curl, and Forgejo/Woodpecker API. However:
  • AC 7 ("Woodpecker CI pipeline triggers on new repo name") — no file target for Woodpecker webhook reconfiguration. The Risks section mentions webhooks may need re-registration but no file target or explicit step covers this. [BODY] Add Woodpecker webhook verification step or note that Forgejo rename auto-redirects webhooks.
  • No test commands specified — kubectl commands are in AC but not in a Test Expectations section.

Blast Radius

  • pal-e-services — 3 files reference "westside-landing" (keycloak.tf, keycloak-import.sh, services.tf). Correctly scoped as "leave alone."
  • Woodpecker CI — webhook URLs will change if repo slug changes. Forgejo auto-redirects, but Woodpecker repo activation may need refresh.
  • ArgoCD — Application source repo URL will need updating if it points to the old Forgejo repo path. Not mentioned in file targets. [BODY] Verify whether ArgoCD Application manifests reference the repo URL directly.
  • Dev overlay — local path changes from /home/ldraney/westside-landing to /home/ldraney/westside-app. Local checkout is already at ~/westside-app, so this is a correction.

Decomposition Assessment

NEEDS DECOMPOSITION.
  • 5 file targets across 2 repos + 1 manual Forgejo action = 3 distinct systems
  • 8 acceptance criteria
  • Estimated agent work: ~10 minutes (multi-repo PRs + Forgejo API rename + ArgoCD sync verification)
  • Natural decomposition: (1) Forgejo repo rename, (2) pal-e-deployments k8s manifests, (3) pal-e-platform monitoring probe, (4) local remote URL update + validation
[DECOMPOSE] 8 AC across 3 systems, route to skill-decompose-ticket

Recommendations

  • [SCOPE] Create architecture note arch-westside-app for the westside-app component
  • [SCOPE] Close or remove duplicate board item #780 (superseded by #920)
  • [BODY] Add explicit Repo header listing all 3 affected systems (pal-e-deployments, pal-e-platform, Forgejo admin)
  • [BODY] Add User Story in as-a/I-want/so-that format
  • [BODY] Add Lineage: "Reversal of #587-#590 (westside-app → westside-landing rename)"
  • [BODY] Clarify Woodpecker webhook handling — does Forgejo auto-redirect suffice or is manual re-registration needed?
  • [BODY] Verify ArgoCD Application source repo URL — add to file targets if it references the old repo path
  • [DECOMPOSE] 8 AC across 3 systems exceeds 5-minute rule. Route to skill-decompose-ticket for sub-board creation.