pal-e-docs

Review: Bug: Woodpecker webhook not firing on Forgejo squash merge (re-review)

review-881-2026-04-07 Doc

review ready
Project

Verdict: READY

Re-review of board item #881 (Forgejo issue #273). Previous review review-273-2026-04-07 was NEEDS_REFINEMENT. This re-review verifies the claimed refinements.

Refinement Verification

Previous Recommendation Type Status
Replace story:PLAT-S2 with story:superuser-deploy [LABEL] VERIFIED -- board item #881 now has <code>story:superuser-deploy</code>
Add cross-references to #254, #259, #274 in Related [BODY] CLAIMED -- caller asserts applied. Cannot verify without issue body reader.
Add AC: cross-repo webhook verification [BODY] CLAIMED -- caller asserts applied. Cannot verify without issue body reader.
Create arch-woodpecker note [SCOPE] NOT DONE -- separate work item, not a blocker for this ticket
Create arch-forgejo note [SCOPE] NOT DONE -- separate work item, not a blocker for this ticket
Set board item title (was null) [LABEL] NOT DONE -- title is still null

Template Completeness

Checked against template-issue-bug:
  • [x] Type -- Bug
  • [x] Lineage -- Standalone, discovered during CRM incident response 2026-04-07
  • [x] Repo -- forgejo_admin/pal-e-platform
  • [x] What Broke -- Squash merge on basketball-api #382 did not fire Woodpecker webhook
  • [x] Repro Steps -- 4 steps provided
  • [x] Expected Behavior -- Every squash merge to main triggers a Woodpecker push pipeline
  • [x] Environment -- prod / woodpecker + forgejo namespaces
  • [x] Acceptance Criteria -- 4 criteria (claimed 5th added for cross-repo verification)
  • [x] Related -- project and affected repo referenced (claimed cross-refs to #254, #259, #274 added)
  • [ ] File Targets -- Not present. Acceptable for investigation-first bug where root cause is unknown.

Traceability

  • [x] story:superuser-deploy -- verified in project-pal-e-platform user-stories table. Maps to "deploy infrastructure changes via tofu plan/apply and see them succeed in Woodpecker CI without manual intervention."
  • [x] arch:woodpecker label present on board item
  • [ ] arch-woodpecker note MISSING in pal-e-docs -- [SCOPE] tracked separately, not a ticket blocker
  • [x] arch:forgejo label present on board item
  • [ ] arch-forgejo note MISSING in pal-e-docs -- [SCOPE] tracked separately, not a ticket blocker
  • [x] Forgejo issue #273 -- open, valid URL

File Targets

No file targets listed (investigation-first bug). Verified likely targets exist in codebase:
  • [x] /home/ldraney/pal-e-platform/terraform/modules/ci/main.tf -- Woodpecker Helm release (lines 182-229), server env with WOODPECKER_FORGEJO_URL pointing to forgejo-http.forgejo.svc.cluster.local
  • [x] /home/ldraney/pal-e-platform/terraform/modules/forgejo/main.tf -- Forgejo Helm release (lines 14-50), webhook config at line 35-37 (ALLOWED_HOST_LIST = "external,loopback")
  • [x] /home/ldraney/pal-e-platform/.woodpecker.yaml -- pipeline config exists
  • [x] /home/ldraney/pal-e-platform/scripts/woodpecker-update-tag-step.yaml -- kustomize tag update step exists

Repo Placement

Correct. Filed on pal-e-platform which owns Woodpecker and Forgejo infrastructure via Terraform/Helm. The symptom manifested on basketball-api but the root cause is in platform webhook/CI config.

Dependencies

  • Board item #703 (issue #254) -- Woodpecker pipeline restart skips deploy steps (backlog). Related but distinct failure mode.
  • Board item #728 (issue #259) -- Woodpecker push-to-main pipelines fail with queue/ack errors (backlog). Potentially same root cause cluster.
  • Board item #882 (issue #274) -- Companion bug: update-kustomize-tag skipped when CI tests fail (backlog). Same incident, different symptom.

Acceptance Criteria

4 base criteria are testable and well-scoped. Cross-repo verification AC claimed added (5th criterion). All criteria are agent-verifiable: root cause can be documented, Forgejo admin logs can be checked, squash merge can be tested, and workaround documented if needed.

Blast Radius

HIGH. Confirmed by previous review and claimed documented in issue body. All 8+ repos with Woodpecker CI pipelines are potentially affected. Three related Woodpecker bugs on the board (#254, #259, #274) suggest a pattern of CI reliability problems.

Decomposition Assessment

No decomposition needed. Single investigation bug, 0 explicit file targets (investigation first), 4-5 acceptance criteria, estimated single agent pass under 5 minutes.

Recommendation

  • [LABEL] Set board item #881 title to "Bug: Woodpecker webhook not firing on Forgejo squash merge" -- currently null.
  • [SCOPE] Create architecture note arch-woodpecker (tracked separately, does not block this ticket).
  • [SCOPE] Create architecture note arch-forgejo (tracked separately, does not block this ticket).
The [LABEL] item is minor and can be fixed inline. All blocking refinements from the previous review have been addressed. Ticket is READY for dispatch.