Review: Validation agent: Playwright-based role validation for westside-basketball

Verdict: READY

Template Completeness

• [x] Type — Feature
• [x] Lineage — present with story, arch, blocked-by, blocks references
• [x] Repo — forgejo_admin/claude-custom
• [x] User Story — well-formed "As a superadmin..." statement
• [x] Context — thorough, explains what exists today, decision rationale, test accounts with credentials, validation mechanism, and Keycloak login flow
• [x] File Targets — single target: ~/.claude/skills/validate-ui/SKILL.md
• [x] Acceptance Criteria — 6 criteria listed, all testable
• [x] Test Expectations — 4 test scenarios
• [x] Constraints — 5 constraints listed
• [x] Checklist — 9 items (4 implementation + 4 test runs + 1 create file)
• [x] Related — links to Playwright MCP, westside PRs, existing skill

Traceability

• [x] story:validation-execute label — "As the superadmin, I want an automated agent that validates deployed features by logging in as each role..."
• [x] story note verified — found in project-pal-e-agency user-stories section. The Validation agent row matches: "I receive a merged PR and its acceptance criteria. I log in as each relevant role via Playwright, navigate the deployed UI, take screenshots, and validate the user experience matches the spec."
• [x] arch:claude-custom label — references the hooks/skills/agents repo
• [ ] arch note MISSING — searched pal-e-docs for "arch-claude-custom", no matching note found. [SCOPE] Create architecture note arch-claude-custom for the claude-custom component. Not blocking: discovered scope, tracked from first review. Does not affect implementability.
• [x] Forgejo issue — forgejo_admin/claude-custom#235, state: open

File Targets

• [x] ~/.claude/skills/validate-ui/SKILL.md — does not exist yet (new file, expected). Path follows existing skill convention: skills/{name}/SKILL.md matches skills/validate-ticket/SKILL.md, skills/review-ticket/SKILL.md, etc. Confirmed by listing ~/claude-custom/skills/ — 28 skill subdirectories, all use this pattern.
• [x] Playwright MCP confirmed — ~/.mcp.json contains playwright server config with headless chromium at ~/.cache/ms-playwright/chromium-1208/chrome-linux64/chrome. Binary verified present (270MB).
• [x] Existing validate-ticket skill confirmed at ~/claude-custom/skills/validate-ticket/SKILL.md — currently does NOT use Playwright (grep for browser_snapshot/browser_take_screenshot/playwright returned zero hits across all skills). No naming collision.

Previous Issues — Resolution Status

• [x] Issue 1 (arch-claude-custom note missing) — Still missing, but correctly tracked as discovered scope [SCOPE]. Not blocking implementation.
• [x] Issue 2 (agent vs skill undecided) — RESOLVED. Issue body now states: "Decision: Skill, not agent." File target updated to skills/validate-ui/SKILL.md following convention.
• [x] Issue 3 (Keycloak passwords not specified) — RESOLVED. Issue body now documents all 3 test accounts with password Westside2026! and email/role mapping: marcusdraney23 (admin+coach+player), ken10seka (coach), apaisasandra (parent/player, 3 kids 2 teams).
• [x] Issue 4 (AC3 validation mechanism vague) — RESOLVED. Issue body now specifies: browser_snapshot for text content validation against AC, browser_take_screenshot for visual evidence. Also documents browser_fill + browser_click for login form.

Repo Placement

Dependencies

• [x] Playwright MCP — confirmed wired in ~/.mcp.json with working chrome binary. Satisfied.
• [x] Keycloak test account credentials — NOW DOCUMENTED: all use Westside2026! with email/role mapping in issue body. Satisfied.
• [x] Board item #518 (Right-side validation pipeline) — in backlog on board-pal-e-agency. Broader validation pipeline feature. Not blocking.
• [x] Items #804, #808, #809, #810, #815 — confirmed on board-westside-basketball in needs_approval column. These are the immediate consumers awaiting this skill. Dependency correctly documented and verified.

Acceptance Criteria

• [x] AC1: "Skill accepts parameters: role, URL, acceptance criteria text" — testable, clear
• [x] AC2: "Skill logs into Keycloak via Playwright (fill email/password form, handle redirect)" — testable, credentials documented
• [x] AC3: "Skill captures browser_snapshot and validates text content against acceptance criteria" — testable, mechanism now specified (browser_snapshot for text, comparison against AC)
• [x] AC4: "Skill captures browser_take_screenshot as visual evidence" — testable, clear
• [x] AC5: "Skill reports PASS/PARTIAL/FAIL verdict with screenshot path and matched/unmatched criteria" — testable, clear
• [x] AC6: "Works with existing Playwright MCP server (no new infrastructure)" — testable, MCP config verified

Blast Radius

• No existing skills use Playwright (grep confirmed zero hits for browser_snapshot/browser_take_screenshot across all 28 skills). This is the first Playwright-consuming skill. No conflict.
• The existing /validate-ticket skill is complementary, not replaced. Integration between the two is out of scope (correctly deferred).
• The role test matrix is westside-specific but AC5 requires parameterized inputs (role + URL + AC text), making the skill reusable. Good design.
• Rollback is trivial — delete the single new file.

Decomposition Assessment

• File targets: 1 new file, 1 repo. Under the 3-file limit.
• Acceptance criteria: 6. Slightly over 5 but tightly coupled (all parts of one Playwright flow: login, navigate, snapshot, screenshot, verdict).
• Estimated agent time: ~3-4 minutes. Under 5-minute rule. Single SKILL.md file with Playwright flow instructions.
• No independent subtasks — sequential flow (login → navigate → validate → report).

Recommendation

• [SCOPE] Create architecture note arch-claude-custom for the claude-custom component. Carried forward from first review — not blocking dispatch.