Review: Subscription list parent_phone (Mismatch 6)

review-746-2026-04-03 Doc

review ready

Project

Verdict: READY

Template Completeness

[x] Type — Feature
[x] Lineage — References spike #278
[x] Repo — forgejo_admin/basketball-api
[x] User Story
[x] Context
[x] File Targets
[x] Acceptance Criteria (3 items)
[x] Test Expectations
[x] Constraints
[x] Checklist
[x] Related

Traceability

[x] story:WS-S12 label — verified in project-westside-basketball user-stories
[x] arch:basketball-api label — present on board item
[ ] arch note MISSING — [SCOPE] Create architecture note arch-basketball-api
[x] Forgejo issue — forgejo_admin/basketball-api#286, open

File Targets

[x] src/basketball_api/routes/subscriptions.py — verified: SubscriptionListItem at line 57. Has player_id, player_name, parent_name, parent_email, subscription_status, stripe_customer_id, stripe_subscription_id. Missing parent_phone as ticket states.

Repo Placement

OK — issue filed on basketball-api, work is in basketball-api. Single-repo scope.

Dependencies

[x] No blocking dependencies. Simplest of the batch — single field addition.

Acceptance Criteria

3 AC items, all testable. Single field addition with null handling. Minimal, clear, specific.

Blast Radius

Additive-only. Lowest blast radius of the batch — 1 model, 1 field. Rollback is trivial.

Decomposition Assessment

1 file target, 3 AC, single repo. Estimated agent time <3 minutes. No decomposition needed. Smallest ticket in the batch.

Recommendation

[SCOPE] Create architecture note arch-basketball-api