Review v2: Coach profile page contract (Mismatch 8)

review-745-2026-04-03-v2 Doc

review ready

Verdict: APPROVED

Re-review after refinement. Previous review: review-745-2026-04-03 (NEEDS_REFINEMENT).

Changes Made

  • Removed optional API scope (photo_url, bio) — if desired, create separate basketball-api ticket
  • Fixed file path: src/routes/coaches/[id]/+page.svelte corrected to src/routes/(app)/coaches/[id]/+page.svelte
  • Re-typed from Feature to Bug (field mapping fix, not new functionality)
  • Reduced AC from 4 to 3 (removed optional API AC)
  • Added explicit note that PR goes to westside-landing despite issue being on basketball-api
  • Added "Files NOT to touch" section

Template Completeness

  • [x] All required sections present

Traceability

  • [x] story:WS-S12 label — verified
  • [x] arch:westside-app label — present
  • [ ] arch note MISSING — [SCOPE] Create architecture note arch-westside-app (deferred)
  • [x] Forgejo issue — basketball-api#285, open

File Targets

  • [x] src/routes/(app)/coaches/[id]/+page.svelte — verified: line 55 uses coach.title (should be coach.role), line 95 uses coach.teams

Repo Placement

Issue filed on basketball-api but work is in westside-landing. Issue body now explicitly directs the executing agent to open PR on westside-landing. Acceptable — moving the issue across repos would break the existing board item link.

Acceptance Criteria

3 AC, all frontend-side. Single file, <5 minutes. No decomposition needed.

Decomposition

1 file, 3 AC. <5 minutes. No decomposition needed.

Recommendation

  • [SCOPE] Create architecture note arch-westside-app (deferred — does not block execution)