Review v2: Team detail page contract (Mismatch 9)

review-744-2026-04-03-v2 Doc

review ready

Verdict: APPROVED

Re-review after refinement. Previous review: review-744-2026-04-03 (NEEDS_REFINEMENT).

Changes Made

  • Re-scoped from cross-repo (basketball-api + westside-landing) to API-only (basketball-api)
  • Removed frontend file target and AC #5 — frontend already uses team.coaches plural array, coach.role, coach.phone
  • Fixed title to indicate API-only scope
  • Reduced AC from 6 to 5
  • Added explicit "Files NOT to touch" section
  • Updated context to explain frontend is already compatible

Template Completeness

  • [x] All required sections present

Traceability

  • [x] story:WS-S12 label — verified
  • [x] arch:basketball-api label — present
  • [ ] arch note MISSING — [SCOPE] Create architecture note arch-basketball-api (deferred)
  • [x] Forgejo issue — basketball-api#284, open

File Targets

  • [x] src/basketball_api/routes/teams.py — verified: TeamDetail has singular coach, CoachBrief missing role/phone, PlayerBrief missing height/jersey_number

Repo Placement

OK. Single-repo ticket on basketball-api. Correct.

Acceptance Criteria

5 AC, all API-side, all verifiable via pytest. Fits single agent pass.

Decomposition

1 file, 5 AC. <5 minutes. No decomposition needed.

Recommendation

  • [SCOPE] Create architecture note arch-basketball-api (deferred — does not block execution)