Review: Coach dashboard parent contact (Mismatch 4)

review-743-2026-04-03 Doc

review ready

Verdict: READY

Template Completeness

  • [x] Type — Feature
  • [x] Lineage — References spike #278
  • [x] Repo — forgejo_admin/basketball-api
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria (5 items)
  • [x] Test Expectations
  • [x] Constraints — documents school/current_school field mapping
  • [x] Checklist
  • [x] Related

Traceability

  • [x] story:WS-S12 label — verified in project-westside-basketball user-stories
  • [x] arch:basketball-api label — present on board item
  • [ ] arch note MISSING — [SCOPE] Create architecture note arch-basketball-api
  • [x] Forgejo issue — forgejo_admin/basketball-api#283, open

File Targets

  • [x] src/basketball_api/routes/coaches_api.py — verified: CoachPlayerBrief at line 27 with fields id, name, position, division, graduating_class. Missing parent_phone, school, and height as ticket states.

Repo Placement

OK — issue filed on basketball-api, work is in basketball-api. Single-repo scope.

Dependencies

  • [x] No blocking dependencies. Independent of sibling tickets.

Acceptance Criteria

5 AC items, all testable. Field mapping constraint (school from current_school) is well documented in Constraints section.

Blast Radius

Additive-only. Coach dashboard frontend will consume new fields. Rollback is trivial (1 file).

Decomposition Assessment

1 file target, 5 AC, single repo. All changes in one model + endpoint. Estimated agent time <5 minutes. No decomposition needed.

Recommendation

  • [SCOPE] Create architecture note arch-basketball-api