Review: Parent dashboard enrichment (Mismatch 3)

review-742-2026-04-03 Doc

review ready

Project

Verdict: READY

Template Completeness

[x] Type — Feature
[x] Lineage — References spike #278
[x] Repo — forgejo_admin/basketball-api
[x] User Story
[x] Context
[x] File Targets
[x] Acceptance Criteria (5 items)
[x] Test Expectations
[x] Constraints
[x] Checklist
[x] Related

Traceability

[x] story:WS-S12 label — verified in project-westside-basketball user-stories
[x] arch:basketball-api label — present on board item
[ ] arch note MISSING — [SCOPE] Create architecture note arch-basketball-api
[x] Forgejo issue — forgejo_admin/basketball-api#282, open

File Targets

[x] src/basketball_api/routes/account.py — verified: AccountPlayerResponse at line 26. Currently has id, name, status, team_name, subscription_status, contract_status, division, position, graduating_class, photo_url. Missing coach_name, team_id, and height as ticket states.

Repo Placement

OK — issue filed on basketball-api, work is in basketball-api. Single-repo scope.

Dependencies

[x] No blocking dependencies. Independent of sibling mismatch tickets.

Acceptance Criteria

5 AC items, all testable. Clear field additions with null handling for unassigned players.

Blast Radius

Additive-only. Parent dashboard frontend will consume new fields. Rollback is trivial (1 file).

Decomposition Assessment

1 file target, 5 AC, single repo. All changes in one model + endpoint. Estimated agent time <5 minutes. No decomposition needed.

Recommendation

[SCOPE] Create architecture note arch-basketball-api