Review: Admin CRM missing parent fields (Mismatches 2,5,7)

review-741-2026-04-03 Doc

review ready

Project

Verdict: READY

Template Completeness

[x] Type — Feature
[x] Lineage — References spike #278, prior fix #276
[x] Repo — forgejo_admin/basketball-api
[x] User Story
[x] Context
[x] File Targets
[x] Acceptance Criteria (4 items)
[x] Test Expectations
[x] Constraints
[x] Checklist
[x] Related

Traceability

[x] story:WS-S12 label — verified in project-westside-basketball user-stories
[x] arch:basketball-api label — present on board item
[ ] arch note MISSING — [SCOPE] Create architecture note arch-basketball-api
[x] Forgejo issue — forgejo_admin/basketball-api#281, open

File Targets

[x] src/basketball_api/routes/admin.py — verified: IncompletePlayerItem at line 403 (has parent_email, parent_name but no parent_phone). TeamPlayerItem at line 651 (no parent_phone or parent_email). Ticket accurately describes the gaps.

Repo Placement

OK — issue filed on basketball-api, work is in basketball-api. Single-repo scope.

Dependencies

[x] AdminPlayerItem.parent_phone already shipped in #276 — ticket correctly scoped to avoid duplication.
[x] No blocking dependencies from sibling tickets.

Acceptance Criteria

4 AC items, all testable. Clear field additions with null handling specified.

Blast Radius

Additive-only. No downstream breakage. 1 file, 2 models. Rollback is trivial.

Decomposition Assessment

1 file target, 2 models to update, 4 AC, single repo. Estimated agent time <5 minutes. No decomposition needed.

Recommendation

[SCOPE] Create architecture note arch-basketball-api