pal-e-docs

Review: Fix stale jersey deadline text (March 28 → April 10)

review-659-2026-03-29 Doc

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type — Bug
  • [x] Lineage — blocker for basketball-api#243 (jersey email send)
  • [x] Repo — forgejo_admin/westside-landing
  • [x] What Broke — hardcoded "March 28" deadline in two places on jersey page
  • [x] Repro Steps — navigate to jersey page, observe stale date; cancel, observe stale date
  • [x] Expected Behavior — both pages should say "April 10"
  • [x] Environment — prod cluster westsidekingsandqueens, cosmetic/copy issue
  • [x] Acceptance Criteria — 4 criteria, all testable
  • [x] Related — project-westside-basketball and basketball-api#243 referenced
Bug template does not require File Targets, User Story, Test Expectations, Constraints, or Checklist sections. All required bug-template sections are present.

Traceability

  • [x] story:WS-S18 — jersey ordering story
  • [x] arch:westside-app — correct architecture component
  • [x] Forgejo issue — westside-landing#180, open

File Targets

Issue body does not list explicit file paths (bug template uses Repro Steps instead). Verified via grep:
  • [x] src/routes/(app)/jersey/+page.svelte:276 — confirmed: contains "Jerseys must be ordered by March 28 to arrive in time for our April tournament"
  • [x] src/routes/(app)/jersey/cancel/+page.svelte:37 — confirmed: contains "You can come back and order anytime before March 28."
A third "March 28" reference exists at src/routes/(public)/tryouts/+page.svelte:68 ("rosters announced March 28") — this is historical fact, not a deadline. Not in scope.

Repo Placement

Correct. Issue filed on forgejo_admin/westside-landing. Local checkout ~/westside-app remote origin confirms same repo. Single-repo fix, no cross-repo concerns.

Dependencies

  • [x] This ticket blocks basketball-api#243 (jersey email send) — documented in Lineage. The email cannot go out while the landing page shows a past deadline.
  • [x] Board item #662 (same story WS-S18, feature type) is in backlog — no conflict or ordering dependency.
  • [x] No in_progress items block or are blocked by this ticket.

Acceptance Criteria

4 criteria from the Forgejo issue, all verifiable:
  • "Jersey page shows April 10 deadline" — grep src/routes/(app)/jersey/+page.svelte for "April 10" after fix.
  • "Cancel page shows April 10 deadline" — grep src/routes/(app)/jersey/cancel/+page.svelte for "April 10" after fix.
  • "Bug no longer reproduces" — confirmed by the string replacements above.
  • "No regression in related functionality" — copy-only change, no logic touched. Rollback is trivial (revert two strings).

Blast Radius

  • 2 files touched, both in the same route group (app)/jersey.
  • No logic changes — pure string replacement of deadline copy.
  • Searched sibling services: basketball-api, pal-e-mail, westside-contracts — no "March 28" deadline text found.
  • Rollback: revert two strings. Trivial.

Decomposition Assessment

Apply three-thing limit and five-minute rule:
  • 2 string replacements in 2 files, 1 repo — well under 3-change limit.
  • 4 acceptance criteria — under the 5 threshold.
  • Estimated agent time: <2 minutes.
  • No independent subtasks to parallelize.
No decomposition needed.

Recommendation

No action needed. Ticket is ready for dispatch.
  • [BODY] Optional enhancement: add explicit file paths to issue body for agent precision (src/routes/(app)/jersey/+page.svelte:276 and src/routes/(app)/jersey/cancel/+page.svelte:37). Not blocking — agent can find them via grep from repro steps.