Review: Enhance skill-review-ticket: verify arch/story notes, auto-decompose

review-591-2026-03-29 Review

review ready

Verdict: READY

Re-review after refinements. Labels corrected (story:pm-scope applied, arch:skills registered in convention-architecture-ids). Scope is solid, traceability complete, fits single agent pass.

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- discovered during westside roster session 2026-03-28
  • [x] Repo -- forgejo_admin/claude-custom
  • [x] User Story -- present (references PM role)
  • [x] Context -- thorough gap analysis listing 4 specific gaps with proposed solutions
  • [x] File Targets -- skill-review-ticket note + potential skill-decompose-ticket
  • [x] Acceptance Criteria -- 4 items, all verifiable
  • [x] Test Expectations -- 2 items with concrete scenarios
  • [x] Constraints -- 3 constraints (pal-e-docs note update, must not break existing flow, decomposition opt-in)
  • [x] Checklist -- standard 3-item
  • [x] Related -- lists skill and project

Traceability

  • [x] story:pm-scope -- PM (Ava): "I can triage boards, scope work into plans/phases/issues, dispatch agents, and run /update-docs without ambiguity." Verified on project-pal-e-agency user-stories table. (Previously story:agency -- fixed.)
  • [x] arch:skills -- "Claude Code skills (review-ticket, validate-ticket, update-docs, etc.)" Verified registered in convention-architecture-ids data-flow-components table. (Previously unregistered -- now added.)
  • [x] Forgejo issue -- claude-custom#217, open

File Targets

  • [x] skill-review-ticket note in pal-e-docs -- verified exists (note ID 605, slug skill-review-ticket, note_type skill, tags: active, skill, updated 2026-03-28)
  • [x] skill-decompose-ticket (potential create) -- confirmed does not exist yet. Creation is part of the scope, acceptable.

Repo Placement

OK. Issue filed on forgejo_admin/claude-custom. Actual work is pal-e-docs note updates via MCP API -- no code changes in claude-custom itself. Consistent with other skill tickets (#656, #364). Single-repo scope.

Dependencies

No blocking dependencies found. Related board items:
  • [x] Item #364 (Scope review pipeline: jidoka for the left side) -- done. Satisfied.
  • [x] Item #656 (Create /validate-ticket skill) -- done. Changes to skill-review-ticket should consider parity with skill-validate-ticket.
  • [x] No items in in_progress or next_up block this ticket.
  • [ ] Item #634 (Review note audit: naming, types, lifecycle) -- backlog. Related but not blocking. May affect review note naming/typing conventions.
  • skill-refine-ticket -- downstream consumer of review output tags ([SCOPE], [BODY], [LABEL], [DECOMPOSE]). This ticket adds new recommendation scenarios using existing tag vocabulary. No breaking change.

Acceptance Criteria

4 criteria, all agent-verifiable:
  • AC 1-2: Testable by running /review-ticket against a ticket with known-missing arch/story notes and confirming they get flagged.
  • AC 3: Testable by checking review note output for [SCOPE] tags on missing notes.
  • AC 4: Testable by reading the updated skill note for decomposition routing documentation.
Test expectations describe two real scenarios. No ambiguous "works correctly" language. Solid.

Blast Radius

  • skill-review-ticket note in pal-e-docs -- direct target, prose update only.
  • skill-validate-ticket -- sibling skill that mirrors review pattern. Not directly affected, but changes should be stylistically consistent.
  • skill-refine-ticket -- downstream consumer of review output tags. Uses existing [SCOPE]/[DECOMPOSE] vocabulary. No breaking change.
  • check-board-advance hook -- reads review note verdicts. Already accepts both APPROVED and READY. Verdict format unchanged. No impact.
  • If skill-decompose-ticket is created as a new skill, the SKILL.md router may eventually need to route to it. But AC 4 scopes this as "documented" not "implemented."
  • Rollback: trivial -- revert the note content via MCP update.

Decomposition Assessment

Three-thing limit: 1 primary note update + 1 potential new note creation = 2 discrete changes (under 3). Five-minute rule: updating skill note content via MCP is well under 5 minutes. AC count: 4 (under 5 threshold). Repos: 1 (pal-e-docs via MCP). No independent subtasks that need parallelization. No decomposition needed.

Recommendation

  • [BODY] User story says "As Betty Sue" -- update to "As Ava" per the Betty Sue to Ava rename (claude-custom#224, done). Minor cosmetic fix, non-blocking.
Previous NEEDS_REFINEMENT recommendations (both [LABEL] fixes) have been resolved: story:pm-scope applied, arch:skills registered. No blocking issues remain. Ticket is READY for execution.