pal-e-docs

Review: Update blackbox probe westside-app to westside-landing

review-590-2026-03-28 Doc

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related
All 11 sections present and complete.

Traceability

  • [x] story:WS-S26 label
  • [x] arch:landing-site label
  • [x] Forgejo issue -- forgejo_admin/pal-e-platform#229, open

File Targets

  • [x] terraform/modules/monitoring/main.tf lines 366-368 -- VERIFIED. Line 366: name = "westside-app", line 367: url = "http://westside-app.westsidekingsandqueens.svc.cluster.local:3000", line 368: labels = { service = "westside-app", tier = "app" }. All confirmed.
  • [x] Correctly notes terraform/main.tf is NOT the target

Repo Placement

OK -- monitoring module is in pal-e-platform. Correctly filed.

Dependencies

  • [x] Depends on sub-ticket 1 -- documented
  • [ ] NOTE: The probe URL references westside-app.westsidekingsandqueens.svc.cluster.local which is the k8s Service DNS name. If ticket #589 renames the k8s Service, this URL must also change. If ticket #589 does NOT rename the k8s Service, then the probe URL should stay the same and only the probe name and labels.service should change. This cross-dependency with ticket #589 is not documented.

Acceptance Criteria

3 criteria. AC #2 ("Probe URL unchanged, still monitors westsidekingsandqueens.tail5b443a.ts.net") is slightly misleading -- the probe URL in the code is the internal k8s service URL, not the public URL. But the intent is correct (the public-facing hostname doesn't change). Testable via tofu plan. Minor wording nit, not blocking.

Blast Radius

Low. This is a label/name rename in monitoring config only. The probe URL may or may not need changing depending on ticket #589's outcome.

Decomposition

3 lines in 1 file. Well under 5 minutes. No decomposition needed.

Recommendation

READY with one caveat: the probe URL (http://westside-app.westsidekingsandqueens.svc.cluster.local:3000) depends on what ticket #589 decides about k8s Service names. If the k8s Service gets renamed to westside-landing, this URL must also change. Recommend adding a constraint: "If ticket #589 renames the k8s Service, update the probe URL accordingly."
This is a sequencing note, not a blocker. The ticket is dispatchable once #589's scope is finalized.