pal-e-docs

Review: Update ArgoCD overlays: westside-app to westside-landing

review-589-2026-03-29 Review

review approved
Project

Verdict: APPROVED

Scope is solid. All file targets verified in the codebase. Traceability complete. Dependency (sub-ticket 1) already in done. Fits in a single agent pass.

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- sub-ticket of forgejo_admin/westside-app#109
  • [x] Repo -- forgejo_admin/pal-e-deployments
  • [x] User Story -- clear "who wants what and why"
  • [x] Context -- sufficient background for a fresh-context agent
  • [x] File Targets -- specific files listed with modification/exclusion notes
  • [x] Acceptance Criteria -- 3 testable conditions
  • [x] Test Expectations -- kustomize build command + manual verification steps
  • [x] Constraints -- dependency ordering and boundary documented
  • [x] Checklist -- PR, build, scope guard
  • [x] Related -- parent ticket and all 4 sub-tickets cross-referenced

Traceability

  • [x] story:WS-S26 -- westside landing site rename story
  • [x] arch:landing-site -- landing site architecture component
  • [x] Forgejo issue -- forgejo_admin/pal-e-deployments#68, open

File Targets

The issue lists top-level paths but the actual files live under prod/ and dev/ subdirectories. This is a minor path accuracy nit -- the scope boundary is correct and the files are easily discoverable.
  • [x] overlays/westsidekingsandqueens/prod/kustomization.yaml -- verified: 11 references to westside-app (env vars, comments)
  • [x] overlays/westsidekingsandqueens/prod/ingress.yaml -- verified: 2 references (westside-app-funnel name, service name)
  • [x] overlays/westsidekingsandqueens/prod/deployment-patch.yaml -- verified: 4 references (westside-app-auth secret name)
  • [x] overlays/westsidekingsandqueens/dev/deployment.yaml -- verified: 1 reference (hostPath /home/ldraney/westside-app)
  • [x] overlays/basketball-api/prod/kustomization.yaml -- verified: comment only (line 55), correctly excluded from scope
Note: Issue file targets omit prod/ prefix (e.g., says kustomization.yaml but actual path is prod/kustomization.yaml). Also missing explicit mention of dev/deployment.yaml. Minor nit -- agent will find these files via grep.

Repo Placement

OK. Issue filed on forgejo_admin/pal-e-deployments, all target files are in that repo under overlays/westsidekingsandqueens/. Single-repo scope, no cross-repo concerns.

Dependencies

  • [x] #587 (Rename westside-app repo to westside-landing on Forgejo) -- status: satisfied (column: done)
  • [x] #588 (Update terraform refs: westside-app to westside-landing) -- status: parallel (column: backlog, can proceed independently)
  • [x] #590 (Update blackbox probe: westside-app to westside-landing) -- status: independent (column: backlog, no blocking relationship)
No unresolved blockers. The critical dependency (Forgejo repo rename) is complete.

Acceptance Criteria

3 criteria, all verifiable:
  • All westside-app references updated -- testable via grep -r westside-app overlays/westsidekingsandqueens/
  • kustomize build succeeds -- automatable, run command provided in Test Expectations
  • ArgoCD sync + site serving -- manual post-merge verification, acceptable for infrastructure work
Criteria are clear, specific, and testable. No ambiguous language.

Blast Radius

  • Files touched: 4 files in 1 directory (overlays/westsidekingsandqueens/)
  • What could break: ArgoCD sync if references are partially updated or if the Kubernetes secret name (westside-app-auth) is renamed but the actual Secret object is not. The secret rename is out of scope for this ticket (handled by sub-ticket 2 in pal-e-services).
  • Rollback: Straightforward git revert. ArgoCD will auto-sync to previous state.
  • Cross-repo impact: The basketball-api overlay has a commented-out reference to westside-app (line 55). No functional impact. Correctly excluded from scope.

Decomposition Assessment

Apply the three-thing limit and five-minute rule:
  • Discrete changes: 1 (find-and-replace westside-app with westside-landing across 4 files). Well under the 3-change limit.
  • Estimated agent time: Under 3 minutes. Simple text substitution + kustomize build verification.
  • Parallelizable subtasks: None needed. All changes are in the same directory with the same pattern.
No decomposition needed.

Recommendation

  • [BODY] Minor nit: file targets should include prod/ and dev/ subdirectory prefixes (e.g., prod/kustomization.yaml instead of kustomization.yaml). Not blocking -- agent will discover correct paths via grep.
  • [BODY] Minor nit: dev/deployment.yaml contains a westside-app hostPath reference but is not explicitly listed as a file target. Not blocking -- covered by the dev/ wildcard mention.
No action required for approval. Nits are informational.