pal-e-docs

Review: Update ArgoCD overlays westside-app to westside-landing

review-589-2026-03-28 Doc

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related
All 11 sections present.

Traceability

  • [x] story:WS-S26 label
  • [x] arch:landing-site label
  • [x] Forgejo issue -- forgejo_admin/pal-e-deployments#68, open

File Targets -- CRITICAL ISSUES

  • [ ] overlays/westsidekingsandqueens/kustomization.yaml -- DOES NOT EXIST at this path. The actual file is overlays/westsidekingsandqueens/prod/kustomization.yaml. The directory has prod/ and dev/ subdirectories, not flat files.
  • [ ] overlays/westsidekingsandqueens/ingress.yaml -- DOES NOT EXIST. Actual: overlays/westsidekingsandqueens/prod/ingress.yaml
  • [ ] overlays/westsidekingsandqueens/deployment-patch.yaml -- DOES NOT EXIST. Actual: overlays/westsidekingsandqueens/prod/deployment-patch.yaml
  • [ ] overlays/westsidekingsandqueens/dev/ -- EXISTS but only has 1 reference: dev/deployment.yaml line 50 has hostPath /home/ldraney/westside-app which is a filesystem path, not a repo reference.

CRITICAL SCOPE ISSUE: Blanket rename would break the cluster

The AC says "All westside-app references updated to westside-landing" but the 20+ references fall into DIFFERENT categories that must NOT all be renamed:
  • K8s Deployment/Service names (kustomization.yaml lines 17-43): westside-app is the k8s resource name for Deployment and Service. Renaming these changes the actual k8s resource identity, which would:
  • Ingress name (ingress.yaml line 4): westside-app-funnel -- Tailscale funnel name. Renaming triggers funnel re-creation.
  • Secret references (deployment-patch.yaml lines 16, 21, 26, 35): westside-app-auth is a k8s Secret. Renaming these without renaming the actual Secret breaks the pod.
  • Dev hostPath (dev/deployment.yaml line 50): /home/ldraney/westside-app is a filesystem directory. After repo rename, the local clone path may or may not change.

Repo Placement

OK -- correctly filed on pal-e-deployments.

Dependencies

  • [x] Depends on sub-ticket 1 -- documented
  • [ ] MISSING: if k8s resource names change, sub-ticket 4 (monitoring probe) must update the probe URL which references the k8s service name. This cross-dependency is not documented.

Acceptance Criteria

3 criteria. The first criterion ("All westside-app references updated") is dangerously broad. An agent following this literally would rename k8s secrets, service names, and ingress names, causing cluster breakage.

Blast Radius

VERY HIGH. A blanket rename of all references would break: ingress routing, monitoring probes, k8s Secret references, and cause Deployment re-creation with downtime.

Decomposition

Once properly scoped, the actual work may be minimal (possibly just dev/deployment.yaml hostPath and some comments). But the scoping decision is needed first -- which references actually need renaming vs. which are k8s resource identities that should stay?

Recommendation

  • [SCOPE] CRITICAL: Human decision needed -- which westside-app references in the overlays should actually be renamed? The k8s Deployment name, Service name, Ingress name, and Secret name are resource identities with downstream dependencies. Blindly renaming all of them would cause cluster breakage. Options:
  • [BODY] Fix all file paths: add prod/ prefix to kustomization.yaml, ingress.yaml, deployment-patch.yaml
  • [BODY] Replace blanket AC with specific references that should change vs. should not change, categorized by type (resource names, comments, hostPaths)
  • [BODY] Document the Secret rename dependency if k8s resource names are changing