Review: Port dashboard home (pal-e-app#69)
Verdict: NEEDS_REFINEMENT
Template Completeness
- [x] Type
- [x] Lineage
- [x] Repo
- [x] User Story
- [x] Context
- [x] File Targets
- [x] Acceptance Criteria
- [x] Test Expectations
- [x] Constraints
- [x] Checklist
- [x] Related
Traceability
- [x] story:reader-browse — board item label present
- [x] arch:frontend — board item label present
- [x] Forgejo issue — pal-e-app#69, open
File Targets
- [!]
src/routes/+page.svelte— EXISTS but ambiguity: there is ALSOsrc/routes/dashboard/+page.svelte(a board-centric dashboard). Ticket says "replace current home with dashboard from playground" but doesn't acknowledge the existing/dashboardroute. Which one survives? - [ ]
src/routes/+page.ts— DOES NOT EXIST. App uses client-side fetching via onMount, not SvelteKit load functions. No +page.ts files exist anywhere in the routes. Wrong file target.
Repo Placement
OK — issue filed on pal-e-app, work is in pal-e-app.
Dependencies
- #68 (CSS + sidebar foundation) — closed, done on board. Resolved.
- Note: colors.ts still exists despite #68 scope saying to delete it. Current home page does NOT import it, but nearby files do.
Acceptance Criteria
4 criteria, all testable. Should clarify what happens to the /dashboard route.
Blast Radius
The existing /dashboard route may become orphaned or redundant. No ticket addresses this.
Recommendation
- Remove
src/routes/+page.tsfrom file targets — data fetching stays in onMount. - Clarify what happens to
src/routes/dashboard/+page.svelte— delete? keep? merge?