pal-e-docs

Review: ArgoCD repo_url :80 port mismatch — blocks tofu apply

review-460-2026-03-27 Review

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type — Bug
  • [x] Lineage — links to pal-e-platform #201
  • [x] Repo — forgejo_admin/pal-e-services
  • [x] What Broke — clear description of :80 URL mismatch causing manifest generation failure
  • [x] Repro Steps — 3 concrete steps with observable failure
  • [x] Expected Behavior — no-port URL specified
  • [x] Environment — file paths, credential names, and cache keys identified
  • [x] Acceptance Criteria — 3 criteria, all testable
  • [x] Related — links parent ticket #201, related #200, incident #184
  • [x] File Targets — services.tf:148 listed (bonus section for bug template)
  • [x] Test Expectations — tofu plan/apply commands specified (bonus section)
  • [x] Constraints — identifies second file target in main.tf (bonus section)
  • [x] Checklist — PR/apply/no-unrelated-changes (bonus section)
All required bug template sections present. Issue exceeds template with 4 bonus sections.

Traceability

  • [x] story:superuser-deploy — deploy pipeline reliability
  • [x] arch:argocd — ArgoCD component
  • [x] Forgejo issue — forgejo_admin/pal-e-services#36, open
All three legs of the traceability triangle are present.

File Targets

  • [x] terraform/services.tf line 148 — verified: contains http://forgejo-http.forgejo.svc.cluster.local:80/${...}.git
  • [x] terraform/main.tf line 320 — verified: argocd_repository_credentials.forgejo URL also contains :80. Mentioned in Constraints section but not listed under File Targets. Agent will find it via grep.
Both occurrences of :80 confirmed. No other references to the Forgejo internal URL exist in the terraform directory.

Repo Placement

OK. Issue filed on forgejo_admin/pal-e-services, both file targets are in pal-e-services/terraform/. Single-repo fix.

Dependencies

  • Parent ticket pal-e-platform#201 (migrate all apps to pal-e-deployments) is in done on the board — no blocker.
  • Board item #435 (tofu apply blocked by MinIO provider refresh) is in backlog — separate blocker, no dependency.
  • Board item #411 (Harbor connectivity timeout) is in in_progress — unrelated.
  • No blocking dependencies documented or found.

Acceptance Criteria

All 3 criteria are machine-verifiable:
  • tofu plan -lock=false -var-file=k3s.tfvars — shows URL changes only
  • tofu apply — succeeds without SOPS CMP errors
  • ArgoCD sync — verifiable via kubectl get applications -n argocd
Test Expectations section provides the exact commands. Solid.

Blast Radius

Searched entire pal-e-services/terraform/ directory — only 2 references to the Forgejo internal URL exist (services.tf:148, main.tf:320). Both use :80. No other repos reference this internal URL pattern. Fix is contained to pal-e-services.

Recommendation

No action needed. Scope is solid, both file targets verified, traceability complete, single-repo one-line-per-file fix well within the 5-minute agent threshold. The second file target (main.tf:320) is documented in Constraints even though it is not in the File Targets section — an executing agent will find it via grep.