pal-e-docs

Review: Update claude-custom + docs for repo renames

review-444-2026-03-26 Review

review ready
Project

Verdict: READY

Re-review after full rewrite. Original issue (pal-e-app#62) had 6 blocking issues. All 6 resolved in claude-custom#174.

Previous Issues -- Resolution Status

  • Wrong repo -- FIXED. Issue now filed on forgejo_admin/claude-custom#174 (correct repo).
  • 11 missing .md files -- FIXED. All 11 hook files, 5 agent files, 2 skill files, 2 root files listed with specific rename instructions.
  • 3 MEMORY.md files -- FIXED. All 3 MEMORY.md files listed plus "Individual memory .md files referencing old repo names."
  • Blast radius in minio-sdk -- FIXED. ~/minio-sdk/CLAUDE.md explicitly listed under "Other repos' CLAUDE.md files."
  • Architecture diagrams unspecified -- FIXED. project-pal-e-docs listed with "architecture diagrams (3 Mermaid diagrams reference pal-e-docs-mcp node and pal-e-docs namespace)." Acceptance criteria includes "Architecture diagrams updated with new names."
  • Acceptance criteria gaps -- FIXED. 8 concrete acceptance criteria with specific grep commands. 4 test expectations with runnable commands.

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- traces to pal-e-app#62 (moved)
  • [x] Repo -- forgejo_admin/claude-custom
  • [x] User Story -- "As the platform / I want all cross-references updated / So that hooks, agents, docs, and memory files reflect the new names"
  • [x] Context -- explains three renames, clarifies MCP prefix stays unchanged
  • [x] File Targets -- comprehensive: 11 hooks, 5 agents, 2 skills, 2 root, 3 memory, 4 pal-e-docs notes, 3 other repos' CLAUDE.md, plus explicit "NOT touch" list
  • [x] Acceptance Criteria -- 8 items with grep verification commands
  • [x] Test Expectations -- 4 items with runnable commands
  • [x] Constraints -- 5 constraints including MCP prefix preservation
  • [x] Checklist -- 6 items covering PR, notes, memory, other repos, tests
  • [x] Related -- 4 items: 3 prerequisite issues + deferred phase

Traceability

  • [x] story:superuser-maintain label -- present on board item #444
  • [x] arch:convention label -- present on board item #444
  • [x] Forgejo issue -- forgejo_admin/claude-custom#174, open

File Targets

claude-custom hooks (11 files):
  • [x] hooks/session-start-context.sh -- verified: contains PAL_E_DOCS_URL (12 occurrences)
  • [x] hooks/check-note-template.sh -- verified: contains PAL_E_DOCS_URL (2 occurrences)
  • [x] hooks/check-pr-template.sh -- verified: contains PAL_E_DOCS_URL (2 occurrences)
  • [x] hooks/check-issue-template.sh -- verified: contains PAL_E_DOCS_URL (2 occurrences)
  • [x] hooks/board-item-on-merge.sh -- verified: contains PAL_E_DOCS_URL (3 occurrences)
  • [x] hooks/session-start-board-sync.sh -- verified: contains PAL_E_DOCS_URL (2 occurrences)
  • [x] hooks/cleanup-worktrees.sh -- verified: contains $HOME/pal-e-docs, $HOME/pal-e-docs-sdk, $HOME/pal-e-docs-mcp
  • [x] hooks/block-dottie-code-writes.sh -- verified: contains /home/ldraney/pal-e-docs-sdk/* and /home/ldraney/pal-e-docs-mcp/*
  • [x] hooks/inject-subagent-context.sh -- verified: prose references to "pal-e-docs" (repo context in agent descriptions)
  • [x] hooks/stop-doc-checkin.sh -- verified: prose references to "pal-e-docs"
  • [x] hooks/remind-review-loop.sh -- verified: prose references to "pal-e-docs"
claude-custom agents (5 files):
  • [x] agents/betty-sue.md -- verified: exists, references pal-e-docs
  • [x] agents/dev.md -- verified: exists, references pal-e-docs
  • [x] agents/qa.md -- verified: exists, references pal-e-docs
  • [x] agents/dottie.md -- verified: exists, references pal-e-docs
  • [x] agents/penny.md -- verified: exists, references pal-e-docs
claude-custom skills (2 files):
  • [x] skills/review-ticket/SKILL.md -- verified: exists, references pal-e-docs
  • [x] skills/plan/SKILL.md -- verified: exists, references pal-e-docs
claude-custom root (2 files):
  • [x] CLAUDE.md -- verified: exists, references pal-e-docs
  • [x] README.md -- verified: exists, references pal-e-docs
Memory files (3 MEMORY.md + individual files):
  • [x] ~/.claude/projects/-home-ldraney-pal-e-platform/memory/MEMORY.md -- verified: contains ~/pal-e-docs, ~/pal-e-docs-sdk, ~/pal-e-docs-mcp (lines 103-105, 127)
  • [x] ~/.claude/projects/-home-ldraney-pal-e-docs/memory/MEMORY.md -- verified: contains pal-e-docs-mcp reference (line 69)
  • [x] ~/.claude/projects/-home-ldraney-pal-e-services/memory/MEMORY.md -- verified: contains pal-e-docs-mcp reference (line 5)
  • [x] Individual files -- verified: feedback_naming_convention.md contains old repo names
pal-e-docs notes (via MCP):
  • [x] project-pal-e-docs repos table -- verified: still shows old names (pal-e-docs, pal-e-docs-mcp, pal-e-docs-sdk with "planned rename" notes)
  • [x] project-pal-e-docs architecture diagrams -- verified: 3 Mermaid diagrams reference pal-e-docs-mcp node name and pal-e-docs namespace
  • [x] worktree-workflow remote conventions table -- verified: still lists pal-e-docs, pal-e-docs-sdk, pal-e-docs-mcp as repo names
  • [x] convention-sveltekit-spa -- verified: no old repo name references found (clean)
Other repos' CLAUDE.md (3 files):
  • [x] ~/pal-e-app/CLAUDE.md -- verified: exists, references "pal-e-docs API" and PAL_E_DOCS_API_URL
  • [x] ~/pal-e-services/CLAUDE.md -- verified: exists, no pal-e-docs references found (clean)
  • [x] ~/minio-sdk/CLAUDE.md -- verified: contains "Follow pal-e-docs-sdk patterns" (line 53)

Repo Placement

OK. Issue filed on forgejo_admin/claude-custom -- correct, since the primary work is in claude-custom. The issue clearly documents that pal-e-docs notes are updated via MCP (not file writes), other repos' CLAUDE.md files are secondary targets, and memory files are in ~/.claude/. Multi-repo scope is well-documented and appropriate for a single coordinating issue.

Dependencies

  • Board item #439 (pal-e-docs#217 -- API rename) -- backlog on board-pal-e-docs. PREREQUISITE.
  • Board item #440 (pal-e-docs-sdk#38 -- SDK rename) -- backlog on board-pal-e-docs. PREREQUISITE.
  • Board item #441 (pal-e-docs-mcp#50 -- MCP rename) -- backlog on board-pal-e-docs. PREREQUISITE.
  • Constraints section correctly states: "All three repo renames must complete before this ticket starts."
  • All three prerequisites are on the same board (board-pal-e-docs) and currently in backlog.

Acceptance Criteria

All 8 criteria are machine-verifiable:
  • [x] 4 grep commands with expected 0-match results -- agent can run these
  • [x] 1 pal-e-docs project page check -- agent can verify via MCP
  • [x] 1 architecture diagrams check -- agent can verify via MCP get_section
  • [x] 1 session start check -- agent can verify by starting a fresh session
  • [x] 1 hooks check -- agent can verify by triggering hooks
Test expectations include 4 items with runnable commands. All verifiable.

Blast Radius

Minor observation (not blocking): The ~/pal-e-app/CLAUDE.md references PAL_E_DOCS_API_URL as an env var and pal-e-docs-api.tail5b443a.ts.net as a Tailscale funnel hostname. These are infrastructure-level references (env var name, DNS hostname) that may or may not change with the repo rename. The issue lists ~/pal-e-app/CLAUDE.md as a target with "repo references" but does not specify whether PAL_E_DOCS_API_URL and the Tailscale funnel hostname should change. The implementing agent can determine this from context -- the env var refers to the API service, not the repo, and may intentionally keep the "pal-e-docs" project branding even after the repo is renamed to pal-e-api. This is a judgment call for the implementer, not a scope gap.
No unidentified blast radius. Grep across claude-custom, memory files, and referenced repos confirms the issue's file targets are comprehensive.

Recommendation

No action needed. The rewrite addresses all 6 issues from the previous review. File targets are comprehensive and verified against the filesystem and pal-e-docs. Acceptance criteria are machine-testable. Dependencies are documented and all sit on the same board. Repo placement is correct. This ticket is ready to move from backlog to todo.