pal-e-docs

Review: Update claude-custom + docs for repo renames

review-442-2026-03-26 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related

Traceability

  • [x] story:superuser-maintain label -- superuser maintenance story
  • [x] arch:convention label -- convention architecture component
  • [x] Forgejo issue -- forgejo_admin/pal-e-app#62, open
  • [ ] Repo placement -- issue filed on pal-e-app but primary work is in claude-custom (see below)

File Targets

  • [x] hooks/session-start-context.sh -- verified: 18 occurrences of PAL_E_DOCS_URL
  • [x] hooks/cleanup-worktrees.sh -- verified: references $HOME/pal-e-docs, $HOME/pal-e-docs-sdk, $HOME/pal-e-docs-mcp
  • [x] hooks/block-dottie-code-writes.sh -- verified: references /home/ldraney/pal-e-docs-sdk/*, /home/ldraney/pal-e-docs-mcp/*
  • [x] hooks/board-item-on-merge.sh -- verified: 3 occurrences of PAL_E_DOCS_URL (not named in ticket but caught by "All hooks with PAL_E_DOCS_URL")
  • [x] hooks/check-note-template.sh -- verified: 2 occurrences of PAL_E_DOCS_URL (not named in ticket)
  • [x] hooks/check-issue-template.sh -- verified: 2 occurrences of PAL_E_DOCS_URL (not named in ticket)
  • [x] hooks/session-start-board-sync.sh -- verified: 2 occurrences of PAL_E_DOCS_URL (not named in ticket)
  • [x] hooks/check-pr-template.sh -- verified: 2 occurrences of PAL_E_DOCS_URL (not named in ticket)
  • [ ] Agent/skill .md files in claude-custom -- MISSING from ticket. 11 .md files reference pal-e-docs as a repo path (agents/betty-sue.md, agents/dev.md, agents/qa.md, agents/dottie.md, agents/penny.md, skills/review-ticket/SKILL.md, skills/plan/SKILL.md, commands/update-docs.md, CLAUDE.md, README.md, docs/superpowers/specs/2026-03-18-review-ticket-design.md)
  • [ ] MEMORY.md files -- MISSING from ticket. 3 MEMORY.md files in ~/.claude/projects/ reference old repo names: -home-ldraney-pal-e-platform, -home-ldraney-pal-e-docs, -home-ldraney-pal-e-services
  • [ ] ~/minio-sdk/CLAUDE.md -- MISSING from ticket. References "pal-e-docs-sdk patterns"

Repo Placement

MISMATCH. The Forgejo issue is filed on forgejo_admin/pal-e-app but the ticket's own Repo section says the primary work is in forgejo_admin/claude-custom. The issue should be moved to or re-filed on forgejo_admin/claude-custom. The pal-e-docs note updates are done via MCP (no repo needed), so claude-custom is the correct home.

Dependencies

Three hard prerequisites, all correctly documented in Constraints:
  • Board #439: Rename pal-e-docs repo to pal-e-api (backlog) -- NOT STARTED
  • Board #440: Rename pal-e-docs-sdk to pal-e-sdk (backlog) -- NOT STARTED
  • Board #441: Rename pal-e-docs-mcp to pal-e-mcp (backlog) -- NOT STARTED
All three prerequisites are in backlog. This ticket cannot move to next_up until all three are done. The dependency chain is correctly documented.

Acceptance Criteria

Mostly testable. The grep commands in Test Expectations are concrete and verifiable. However:
  • "Session starts without errors" -- testable but vague. Should specify which hook outputs to verify.
  • "All hooks fire correctly" -- needs specificity. Which hooks, what trigger?
  • Missing criterion: agent .md files should also be grepped for old repo paths
  • Missing criterion: MEMORY.md files should be verified
  • Missing criterion: pal-e-docs project page architecture diagrams should be verified post-update

Blast Radius

  • Architecture diagrams in project-pal-e-docs note -- The flowchart references "pal-e-docs-mcp" as a node label. The deployment diagram references namespace "pal-e-docs". These need updating but the ticket only says "architecture diagrams updated" without specifying which diagrams or what changes.
  • minio-sdk/CLAUDE.md -- References "pal-e-docs-sdk patterns" on line 53. Not covered by the ticket scope (different repo). Should be a separate issue or explicitly scoped in.
  • pal-e-deployments -- Verified clean. No old references found.
  • pal-e-services -- Verified clean. No old references found.

Recommendation

Before moving to next_up, fix these issues:
  • Re-file the issue on forgejo_admin/claude-custom (or document why pal-e-app is correct). The repo placement mismatch will confuse the executing agent.
  • Add agent/skill .md files to File Targets -- 11 markdown files in claude-custom reference old repo paths. These are not MCP tool matchers and need updating.
  • Add MEMORY.md files to File Targets -- 3 MEMORY.md files in ~/.claude/projects/ reference old repo names.
  • Add minio-sdk/CLAUDE.md to blast radius or create a separate issue -- It references "pal-e-docs-sdk patterns".
  • Specify architecture diagram changes -- The project-pal-e-docs note has 3 Mermaid diagrams referencing old names (pal-e-docs-mcp in flowchart, pal-e-docs namespace in deployment diagram).
  • Tighten acceptance criteria -- Add grep verification for .md files and MEMORY.md files, not just hooks.