Review: Rename pal-e-docs-sdk to pal-e-sdk + update package

review-440-2026-03-26 Review

review ready

Verdict: READY

Re-review after refinements. All three issues from initial NEEDS_REFINEMENT review have been resolved.

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- references repo rename initiative + upstream dependency on pal-e-docs rename
  • [x] Repo -- correctly identifies forgejo_admin/pal-e-docs-sdk as source and target name
  • [x] User Story -- clear platform naming consistency motivation
  • [x] Context -- adequate background on SDK purpose and rename rationale
  • [x] File Targets -- complete and verified (see below)
  • [x] Acceptance Criteria -- 5 criteria, all testable
  • [x] Test Expectations -- pytest command with relative path, no stale directory reference
  • [x] Constraints -- documents PyPI cleanup, MCP breakage timing, local dir note
  • [x] Checklist -- 5 items covering full delivery
  • [x] Related -- references upstream #217 and downstream #50

Traceability

  • [x] story:superuser-maintain label -- on board item #440
  • [x] arch:sdk label -- on board item #440
  • [x] Forgejo issue -- forgejo_admin/pal-e-docs-sdk#38, open
Traceability triangle is complete.

File Targets

  • [x] pyproject.toml -- verified: contains name = "pal-e-docs-sdk", packages = ["src/pal_e_docs_sdk"], version 0.4.0
  • [x] src/pal_e_docs_sdk/ -- verified: directory exists with 14 modules, 2 internal import references to update
  • [x] .woodpecker.yml -- verified: exists, uses generic paths (src/, tests/, pip install -e). Publish step uses python -m build which reads pyproject.toml -- will work after rename
  • [x] tests/ -- verified: 11 test files + integration/ directory, 31 total pal_e_docs_sdk references that need updating
  • [x] CLAUDE.md -- correctly listed under "Files that do NOT exist" with "do not create" directive (previous issue #1 resolved)
  • [x] Downstream pal-e-docs-mcp -- verified: pyproject.toml dependency, uv.lock refs, server.py import. Correctly scoped out to ticket #441
  • [x] Downstream pal-e-docs-playground/note-project.html -- verified: 2 references to SDK. Now listed in downstream awareness (previous issue #3 resolved)
  • [x] Downstream claude-custom -- verified: 2 files reference repo path. Correctly scoped out to ticket #442

Repo Placement

OK. Issue is filed on forgejo_admin/pal-e-docs-sdk which is the repo being renamed. All downstream consumers explicitly scoped out with separate board items (#441 MCP, #442 claude-custom + docs, #444 claude-custom + docs update).

Dependencies

  • Upstream: Board item #439 "Rename pal-e-docs repo to pal-e-api" (pal-e-docs#217, open, backlog). Documented in Lineage section. Technically the SDK rename could proceed independently since the SDK communicates via URL config, not repo name.
  • Downstream: Board item #441 (pal-e-docs-mcp#50, open) -- MCP server imports from the SDK. Must update after this completes.
  • Downstream: Board item #442 + #444 (claude-custom + docs update) -- depends on all renames completing.

Acceptance Criteria

All 5 criteria are testable. Forgejo API rename is covered in File Targets as a PATCH operation. Test command uses relative path source .venv/bin/activate && pytest (previous issue #2 resolved -- Constraints section clarifies local dir stays at ~/pal-e-docs-sdk until manually renamed).

Blast Radius

  • pal-e-deployments -- no references. Clean.
  • pal-e-services -- no references. Clean.
  • ~/.claude/ MEMORY.md -- lists ~/pal-e-docs-sdk under "Repo Locations." Covered by #442.
  • Forgejo PyPI: old pal-e-docs-sdk package will remain in registry. Constraints section acknowledges "may need manual cleanup" -- adequate.

Previous Issues Resolution

  • CLAUDE.md -- RESOLVED. Now listed under "Files that do NOT exist (confirmed by review)" with explicit "do not create" directive.
  • Test command path -- RESOLVED. Test Expectations now uses relative path source .venv/bin/activate && pytest. Constraints section adds note: "local directory stays at ~/pal-e-docs-sdk until manually renamed."
  • pal-e-docs-playground missing from downstream -- RESOLVED. Now listed under "Files in OTHER repos that depend on this" with specific file reference.

Recommendation

No action needed. All three previous issues have been addressed. Ticket is ready for execution.