pal-e-docs

Review: Update Schedule: Kings/Queens toggle

review-410-2026-03-25 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related

File Targets

  • [x] schedule.html — verified: exists in westside-playground at root. Contains 5 Kings teams (16U Elite, 17U Elite, 17U Select, 16U Local, 17U Local) all with TBD schedules. No toggle currently present. 178 lines.
  • [x] shared/app.js — verified: exists, 462 lines. Contains generic toggle/tab utilities but NO Kings/Queens toggle pattern. Constraint to "add to shared/app.js once, reuse everywhere" is valid but the toggle function does not exist yet.
  • [x] shared/style.css — verified: exists.

Repo Placement

MISMATCH: Forgejo issue #95 is filed on forgejo_admin/westside-app (SvelteKit production app), but the ### Repo field in the scope says forgejo_admin/westside-playground (HTML mock repo). The file target schedule.html exists only in westside-playground. The issue should be filed on the correct repo or the Repo field should be corrected to match where the issue is filed.

Dependencies

UNDOCUMENTED DEPENDENCY: The scope says "Same toggle pattern as Tryouts and Teams pages" and "Consistent toggle UX across all 3 toggled pages." However:
  • Board item #407 (Tryouts page, issue #92) is in todo — tryouts.html does not exist yet
  • Board item #408 (Teams page, issue #93) is in todo — teams.html does not exist yet (only team.html exists, which is an authenticated single-team detail page)
  • No Kings/Queens toggle JS function exists in shared/app.js
  • The toggle pattern must be created by whichever ticket is implemented first. Issue #92 (Tryouts) explicitly says it will create the pattern ("Kings/Queens toggle is light JS in shared/app.js"), while this ticket (#95) says to reuse the pattern ("Same toggle pattern as Tryouts and Teams pages")
This ticket implicitly depends on #92 being done first. That dependency is not documented in the scope or in the board item labels.

Acceptance Criteria

Partially testable. Most criteria are clear and verifiable:
  • [x] "Kings/Queens toggle at top of page" — testable
  • [x] "Kings shows current 5 teams with schedules" — testable, data exists in current schedule.html
  • [x] "Queens shows placeholder (TBD)" — testable
  • [ ] "Same toggle pattern as Tryouts and Teams pages" — NOT testable until those pages exist
  • [ ] "Consistent toggle UX across all 3 toggled pages" — NOT testable until those pages exist

Blast Radius

  • Adding toggle JS to shared/app.js affects all 22 HTML pages that include it. Low risk since it would be additive (new function, called only from pages with toggle markup).
  • The toggle CSS classes added to shared/style.css could collide with existing class names — agent should verify no conflicts.
  • The SvelteKit production app (westside-app) has schedule-adjacent routes but is not affected since this is playground-only work.

Recommendation

Three issues to resolve before this ticket is READY:
  • Fix repo placement: Either move the Forgejo issue to forgejo_admin/westside-playground, or update the ### Repo field to forgejo_admin/westside-app and clarify which repo the work happens in.
  • Document dependency on #92: Add depends:ws-92 label to board item #410, or rewrite this ticket to be self-contained (i.e., this ticket creates the toggle pattern itself, and #92/#93 reuse it).
  • Clarify ordering: If this ticket should be done after #92, state it explicitly. If this ticket should be done first and define the pattern, update the acceptance criteria to remove references to pages that don't exist yet, and add a criterion for creating the reusable toggle function in shared/app.js.