pal-e-docs

Re-review: New page: About

review-406-2026-03-25-r2 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Re-review of board item #406 after refinement posted on issue #91. Previous review: review-406-2026-03-25.

Previous Findings — Resolution Status

# Finding Status Detail
1 Nav lists nonexistent pages (Tryouts, Teams, Gear) NOT RESOLVED Refinement comment says "updated to Home | About | Staff | Sponsors | Schedule" but the <strong>issue body was not edited</strong>. AC #3 still reads the old nav order with pages that don't exist.
2 Undocumented dependency on #90 RESOLVED <code>depends:ws-90</code> label added to board item. Issue #90 is now <strong>closed</strong> (merged). Dependency satisfied.
3 Repo mismatch (westside-app issue, westside-playground target) RESOLVED Refinement comment documents convention: "westside-app tracks, westside-playground is target." Consistent with #85-#88 pattern.

Template Completeness

  • [x] Type
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [ ] Acceptance Criteria — AC #3 not updated to match refinement
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related

File Targets

  • [x] about.html — confirmed: does NOT exist yet (correct, file to create)
  • [x] index.html — verified: About section at lines 64-90 (3 cards + Marcus quote). Matches description.
  • [x] shared/style.css — exists
  • [x] shared/app.js — exists
  • [x] "All pages with nav" — 6 public pages confirmed with nav-links: index.html, staff.html, schedule.html, sponsors.html, register.html, success.html

Repo Placement

OK. Convention documented in refinement comment: westside-app tracks issues, westside-playground is the PR target. Consistent with overhaul series #85-#88.

Dependencies

  • #90 "Landing page: restore original energy" — CLOSED (merged). Dependency satisfied. depends:ws-90 label present on board item.
  • #77 "Public site: travel schedule page + nav updates" — still in next_up. Both modify nav on all pages. Natural kanban flow (next_up before todo) handles ordering, but no explicit dependency documented. Low risk if column discipline holds.

Acceptance Criteria

  • [x] AC 1: "about.html exists with expanded program info" — clear, testable
  • [x] AC 2: "About section removed from index.html" — clear, testable
  • [ ] AC 3: "Nav updated on ALL pages: Home | About | Staff | Tryouts | Teams | Schedule | Gear | Sponsors" — STILL INVALID. Issue body not edited. Agent will implement nav linking to nonexistent pages. Must update to: Home | About | Staff | Sponsors | Schedule
  • [x] AC 4: "Mobile renders clean" — testable via 390px check

Blast Radius

  • Nav duplication across 6+1 files. Same as previous review. Concurrent playground work touching nav will conflict.
  • No blast outside playground. Clean boundary — no SvelteKit or API changes.

New Concern: Kings/Queens Toggle

Refinement comment adds localStorage-based program mode toggle ("~10 lines in shared/app.js") as scope for "all 5 new tickets." This is NOT in the issue body. Either:
  • (a) Add the toggle spec to the issue body if it's in-scope for this ticket, OR
  • (b) Create a separate cross-cutting ticket for the toggle if it should be done once
Recommendation: (b) — a shared utility belongs in one ticket, not duplicated across five.

Recommendation

One blocking action before this ticket is READY:
  • Edit the issue body. Update AC #3 nav order from Home | About | Staff | Tryouts | Teams | Schedule | Gear | Sponsors to Home | About | Staff | Sponsors | Schedule. Agents execute from the issue body, not comments. The refinement intent is correct but not applied to the spec.
One advisory (non-blocking):
  • Kings/Queens toggle. Decide whether this is in-scope for this ticket or a separate cross-cutting ticket. If in-scope, add to issue body. If not, create a standalone issue.