pal-e-docs

Review: New page: About

review-406-2026-03-25 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related
All required template sections are present.

File Targets

  • [x] about.html — confirmed: does NOT exist yet (file to create). Correct.
  • [x] index.html — verified: About section exists at lines 65-90 (3 cards + Marcus quote). Matches ticket description exactly.
  • [x] shared/style.css — verified: exists at shared/style.css
  • [x] shared/app.js — verified: exists at shared/app.js
  • [x] "All pages with nav" — verified: 6 public pages have nav-links: index.html, staff.html, schedule.html, sponsors.html, register.html, success.html. Authenticated pages (admin, coach, etc.) use different nav — no update needed there.

Repo Placement

MISMATCH. The ### Repo field says forgejo_admin/westside-playground but the Forgejo issue is filed on forgejo_admin/westside-app (#91). The file targets are all playground HTML files (about.html, index.html), so the work belongs in the playground repo. The issue should be filed on forgejo_admin/westside-playground, or at minimum, a comment should clarify that the PR targets westside-playground despite the issue living on westside-app. This is a pattern shared with all other playground overhaul issues (#85-#88), which were also filed on westside-app — so it may be intentional convention, but should be documented explicitly.

Dependencies

  • #405 "Landing page: restore original energy" (next_up) — also modifies index.html. That ticket removes the coaches section and restructures the landing page to: Hero → About → Quote → How to Join → CTA → Footer. This ticket (#91) then removes the About section from that same page. These two tickets MUST be ordered: #405 first, then #91. Not documented in this ticket's scope.
  • #77 "Public site: travel schedule page (v1) + nav updates" (next_up) — explicitly mentions updating nav on all pages. Overlapping nav scope with this ticket. Whichever runs second will overwrite the first's nav changes. Ordering or merge strategy not documented.
  • #407 "New page: Tryouts", #408 "New page: Teams", #409 "New page: Gear" (all todo) — these pages are referenced in the acceptance criteria nav order but don't exist yet. This ticket can't link to them.

Acceptance Criteria

  • [x] Criterion 1: "about.html exists with expanded program info" — testable, clear.
  • [x] Criterion 2: "About section removed from index.html" — testable, clear.
  • [ ] Criterion 3: "Nav updated on ALL pages: Home | About | Staff | Tryouts | Teams | Schedule | Gear | Sponsors" — INVALID. Tryouts (tryouts.html), Teams (team.html exists but may not match), and Gear (gear.html) pages don't exist yet. The nav order should only include pages that exist after this ticket completes. Suggested: Home | About | Staff | Sponsors | Schedule (current pages + new About page).
  • [x] Criterion 4: "Mobile renders clean" — testable via 390px visual check.
Test expectations are minimal but appropriate for a playground page (visual check, link resolution, no automated tests).

Blast Radius

  • Nav duplication across 6 files. Every public page has its own nav HTML block. This ticket changes all 6 plus adds a 7th (about.html). Any concurrent playground work touching nav will conflict.
  • Landing page contention. Two tickets in next_up (#405) and todo (#91) both modify index.html. Merge order matters.
  • No blast outside playground. This is playground-only work. No SvelteKit (westside-app) or API changes. Clean boundary.

Recommendation

Three issues to fix before this ticket is READY:
  • Fix acceptance criterion 3. The nav order lists pages that don't exist yet (Tryouts, Teams, Gear). Update to only include pages that will exist after this ticket: Home | About | Staff | Sponsors | Schedule. Or add a note that nav links for future pages should be omitted until those tickets complete.
  • Document the dependency on #405. This ticket removes the About section from index.html, but #405 (next_up) also restructures index.html. Add depends:#405 to the scope or labels, and note that #405 must merge first.
  • Clarify repo filing convention. The issue is filed on westside-app but targets westside-playground. Either move the issue to the correct repo or add a note explaining the cross-repo convention (as done with #85-#88).