pal-e-docs

Review v3: Update 14 SOPs/conventions for kanban-over-plans

review-397-2026-03-26-v3 Review

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related
All required sections from template-issue are present.

File Targets

All 14 notes verified to exist and confirmed to contain plan/phase references that need updating:
  • [x] template-plan -- verified: status=active, note_type=template. Needs status set to deprecated.
  • [x] template-phase -- verified: status=active, note_type=template. Needs status set to deprecated.
  • [x] template-ticket -- verified: Traceability Triangle section has "Phase (note_slug)" as third leg of triangle diagram.
  • [x] template-issue-feature -- verified: Lineage section says "plan-slug-here -> Phase N -> Phase Na (if subphase)".
  • [x] template-issue-bug -- verified: Lineage section says "plan-slug-here -> Phase N (if discovered during plan work)".
  • [x] template-issue-spike -- verified: Lineage section says "plan-slug-here -> Phase N (if scoped from plan work)".
  • [x] agent-workflow -- verified: "Two Work Paths" section has Path 1: "project -> plan -> phases -> Forgejo issues -> agent -> PR".
  • [x] agent-spawn-conventions -- verified: Two Work Paths table has "Feature work: project -> plan -> phases -> Forgejo issues". Minimal Prompt Pattern has "Plan: plan-slug (traceability -- do not read)".
  • [x] convention-todo-lifecycle -- verified: Lifecycle table has "3a. Plan path" row with "New phase or subphase created in plan".
  • [x] sop-board-workflow -- verified: Item Lifecycle "How items arrive" table has plan and phase item_type rows.
  • [x] glossary -- verified: Scoping Pipeline section shows "Project -> Plan -> Phase -> Forgejo Issue -> Agent -> PR -> Merge -> Deploy" chain and "Plan path (strategic)" entry.
  • [x] skill-review-ticket -- verified: Inputs section has "Plan context -- optional phase note slug for plan-driven items".
  • [x] template-issue -- verified: traceability chain "Project -> Plan -> Phase -> Subphase -> Forgejo Issue -> PR", Lineage Examples table with plan slugs, "How Betty Sue Tracks Issues" referencing plan phases.
  • [x] template-pr-body -- verified: Related Notes says "plan-slug -- the plan phase this implements".

Repo Placement

OK. Issue filed on forgejo_admin/claude-custom as tracking repo. Actual work is pal-e-docs MCP updates -- no code files. This matches the Repo and Constraints sections.

Dependencies

Board item #397 is in todo column on board-pal-e-agency. Related items checked:
  • #396 (next_up): "Remove plan/phase hooks from enforcement layer" -- code-side counterpart with arch:enforcement. No hard dependency; docs and hooks can update independently.
  • #395 (next_up): "Upgrade story: label to hard-block + Task type routing" -- mentioned in issue body (Task type workaround). No blocking dependency.
  • #398 (next_up): "Board hygiene" -- no dependency.
No blockers found. No undocumented dependencies.

Acceptance Criteria

All criteria are agent-verifiable:
  • template-plan/phase status = deprecated -- verifiable via get_note checking status field.
  • template-ticket traceability triangle references Forgejo issue -- verifiable via get_section on the triangle block.
  • 3 issue templates updated Lineage -- verifiable via get_section(anchor_id="forgejo-issue-template") on each.
  • agent-workflow single board-driven path -- verifiable via get_section(anchor_id="two-work-paths").
  • agent-spawn-conventions no plan slug -- verifiable via get_section on relevant sections.
  • All 14 notes verified via get_section to confirm plan/phase content removed -- strong verification method (upgraded from get_note_toc per v2 review).
  • skill-review-ticket updates (5 criteria from comment 1) -- each verifiable via get_section.

Blast Radius

Blast radius check found 4 additional notes with plan/phase references NOT in scope:
  • note-conventions -- Note Types table lists plan/phase as active types. Note Decomposition section describes plan-phase hierarchy. However, these describe the data model (plan/phase notes still exist in the DB), not the workflow. Adding deprecation annotations is follow-on work.
  • sop-index -- Templates table lists template-plan and template-phase without deprecation markers. Will need updating once templates are deprecated, but this is a natural consequence.
  • skill-plan -- Active skill for creating plans. Should be deprecated, but that is plan-infrastructure deprecation -- a separate ticket.
  • convention-subphase -- Active convention for subphase creation. Same reasoning as skill-plan.
These 4 notes are plan-creation infrastructure. Deprecating them is a separate ticket from removing plan references from workflow docs. The current ticket correctly focuses on the 14 notes agents and Betty Sue actively read during work execution.

Traceability

  • story:pm-scope -- Betty Sue PM workflow. Valid.
  • arch:kanban -- kanban architecture component. Valid.
  • scope:unplanned -- discovered during audit. Valid.
  • Project: pal-e-agency. Valid.

Recommendation

No action needed. Scope is solid after 4 rounds of refinement. All 14 notes verified, acceptance criteria are testable with get_section, no blockers, blast radius items are separate scope. Ready for dispatch.
Discovered scope for follow-up: Deprecate plan-creation infrastructure (note-conventions plan/phase deprecation annotations, sop-index template markers, skill-plan, convention-subphase).