Re-Review: Public site: travel schedule page (v1) + nav updates

review-356-2026-03-25-r2 Review

review ready

Verdict: READY

Re-review after refinement of board item #356 (Forgejo issue westside-app#77). Previous review: review-356-2026-03-25 (NEEDS_REFINEMENT, 2 issues).

Refinement Verification

  • [x] depends:ws-75 label added — Board item #356 now has labels: type:content,arch:landing-site,story:WS-S26,depends:ws-75. Dependency on issue #75 (strip stale tryout content) is formalized. Issue #75 is closed and board item #354 is in done column with merged:svelte-pr-6.
  • [x] Repo convention documented — A convention note was posted on the Forgejo issue explaining that westside-app is the tracking repo for all west-side-basketball static site issues, since west-side-basketball lives on GitHub only (no Forgejo instance). The issue body already specifies the target repo (ldraney/west-side-basketball) and prototype repo (forgejo_admin/westside-playground) clearly. An agent reading the issue will know where to work.

Template Completeness

  • [x] Lineage — present
  • [x] Repo — present, both target and prototype repos specified
  • [x] User Story — present, well-formed
  • [x] Context — present
  • [x] File Targets — present with create/modify/do-not-touch sections
  • [x] Acceptance Criteria — present, 6 items, all testable
  • [x] Test Expectations — present
  • [x] Constraints — present
  • [x] Checklist — present, covers playground-to-production pipeline
  • [x] Related — present

File Targets

  • [x] schedule.html — to be created (does not exist yet, correct)
  • [x] index.html — verified exists, nav with Tryouts link at line 44
  • [x] staff.html — verified exists, same nav pattern
  • [x] sponsors.html — verified exists, same nav pattern
  • [x] success.html — verified exists, same nav pattern
  • [x] js/main.js — verified exists, nav toggle only, correctly excluded

Repo Placement

Accepted. Convention established: forgejo_admin/westside-app is the catch-all Forgejo tracker for static site issues targeting ldraney/west-side-basketball (GitHub Pages). Issue body clearly specifies both repos. No ambiguity for executing agents.

Dependencies

  • Issue #75 (strip stale tryout content) — closed, board item #354 in done. Dependency satisfied. Note: playground merge completed (merged:svelte-pr-6) but production copy to west-side-basketball may still be pending. Execution sequencing concern only — not a scope issue.
  • Issue #76 (add Coach Manny to staff page) — board item #355, also in todo. Both touch staff.html nav. Low conflict risk since nav is a shared header block. Coordination note from original review still applies.

Acceptance Criteria

All 6 criteria are agent-testable. Mobile-first layout verifiable by phone screenshot. Westside logo is standard shared nav pattern. No gaps.

Blast Radius

Unchanged from original review. Nav update across 4 files is straightforward. No downstream consumers beyond GitHub Pages static serving. Playground gate documented in checklist.

Recommendation

No further action needed. Both refinement items resolved. Ticket is ready for execution.