pal-e-docs

Review: Public site: add Coach Manny to staff page

review-355-2026-03-25 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related

File Targets

  • [x] staff.html — verified: exists in west-side-basketball with 5 existing .coach-card entries (Marcus, James Taylor, KJ Ng, Ken Seka, Abbie Sa)
  • [x] css/style.css — verified: .coach-card styles exist at line 624 (mobile) and line 776 (desktop breakpoint). Correctly marked as "do not touch."
  • [ ] Coach Manny photo — ISSUE: no photo exists in assets/images/ and no photo exists in MinIO. The checklist correctly lists "Manny photo uploaded to MinIO" as prerequisite, but this is currently unmet.

Repo Placement

MISMATCH. The Forgejo issue is filed on forgejo_admin/westside-app (SvelteKit app, Forgejo), but the issue body says the target repo is ldraney/west-side-basketball (static HTML, GitHub Pages). These are different repos on different platforms:
  • westside-app = SvelteKit app on Forgejo (the authenticated platform)
  • west-side-basketball = static public site on GitHub Pages
The issue should either be filed on GitHub (where the target repo lives), or the Forgejo issue body should clarify that the work spans both the playground (Forgejo) and the production public site (GitHub). An agent spawned against westside-app will look at the wrong codebase.

Dependencies

  • Photo prerequisite: Checklist item "Manny photo uploaded to MinIO" must be completed before the card can be built. No photo currently exists.
  • Sibling items: Board items #354 (strip stale tryout content, issue #75) and #356 (travel schedule page, issue #77) share story:WS-S26 and arch:landing-site labels. All three are public site content updates. No blocking dependency between them, but they could be batched into a single PR if desired.
  • Playground gate: Checklist requires playground approval on phone before production copy. Playground (westside-playground) exists locally and on Forgejo but has no Coach Manny content yet.

Acceptance Criteria

  • [x] "Coach Manny card added to staff.html" — clear, verifiable
  • [x] "Same card format as existing coaches" — clear, pattern exists to copy
  • [ ] "Photo referenced from MinIO CDN" — AMBIGUOUS: existing coach photos use local assets/images/ paths (e.g., assets/images/marcus.jpg), not MinIO CDN URLs. If the intent is to use MinIO, this is a pattern break. If the intent is local assets like the others, the criterion text is misleading.
  • [x] "Card renders correctly on mobile" — verifiable via visual check
Missing criteria: no mention of Coach Manny's role title, credentials, or bio content. The agent will need to either make these up or block on content from Marcus/Lucas.

Blast Radius

Low. Adding a new .coach-card article to staff.html is additive. No CSS changes needed. No downstream consumers affected. The same staff.html exists in westside-playground but with no Manny content — playground prototype is a prerequisite per the checklist, not a blast radius concern.

Recommendation

  • Fix repo placement: Either move this issue to a GitHub issue on ldraney/west-side-basketball, or clarify in the issue body that the agent should work in the west-side-basketball repo (not westside-app). Update the board item's Forgejo URL accordingly.
  • Clarify photo source: Change "Photo referenced from MinIO CDN" to either "Photo added to assets/images/" (matching existing pattern) or provide the MinIO CDN URL pattern if that's the intent.
  • Add bio content: Provide Coach Manny's role title, credentials, and coaching philosophy text, or specify who the agent should ask.
  • Upload photo first: The photo prerequisite must be met before this ticket is actionable.