pal-e-docs

Review: Public site: strip stale tryout content + fix practice count

review-354-2026-03-25 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Lineage — present ("Standalone — no plan phase")
  • [x] Repo — present (ldraney/west-side-basketball + westside-playground)
  • [x] User Story — present and well-formed
  • [x] Context — present, explains urgency clearly
  • [x] File Targets — present with line numbers
  • [x] Acceptance Criteria — present (9 items)
  • [x] Test Expectations — present (visual + source search + nav check)
  • [x] Constraints — present (no frameworks, mobile-first, playground gate)
  • [x] Checklist — present (5 items)
  • [x] Related — present
All required template sections are present.

File Targets

  • [x] index.html lines 52-59 (tryout banner) — verified: exact match, contains tryout-banner section with March 13 date and Stripe link
  • [x] index.html lines 109-140 (tryout section) — verified: exact match, contains #tryouts section with details and what-to-bring cards
  • [x] index.html line 90 (About card practice count) — verified: "Three 2-hour team practices per week"
  • [x] index.html line 186 (FAQ practice count) — verified: "Three 2-hour team practices per week"
  • [x] index.html line 147 (How It Works header) — verified: "Three steps to join the team."
  • [x] index.html lines 209-215 (bottom CTA) — verified: Stripe link + "Tryouts are Friday, March 13"
  • [x] index.html line 67 (hero Stripe CTA) — verified: "Sign Up for Tryouts — $30" with Stripe link
All line references are accurate against the current file.

Repo Placement

Minor concern: Repo mismatch. The Forgejo issue is filed on forgejo_admin/westside-app (the SvelteKit app on Forgejo), but the actual target repo is ldraney/west-side-basketball on GitHub Pages. The ticket correctly identifies the target repo in the body, so an agent will know where to work. This is an organizational concern — Forgejo issue state won't track against the actual repo.

Dependencies

  • No blocking dependencies. Nothing in in_progress or next_up blocks this work.
  • Board item #299 (Issue #71: "Practice schedule page — weekly team calendar") is related future work, correctly noted in the ticket's Related section.
  • Board item #355 (Issue #76: "Public site: add Coach Manny to staff page") is a sibling content ticket with the same arch:landing-site label — no conflict, can be done independently.
  • Board item #356 (Issue #77: "Public site: travel schedule page + nav updates") touches nav — agent should coordinate nav changes if both are in flight simultaneously, but no hard dependency.

Acceptance Criteria

Criteria are clear and testable. An agent can verify each one:
  • Removal criteria: grep for "tryout", "Tryouts", "Register Now", "stripe.com" — zero hits = pass
  • Content changes: grep for "Two 2-hour" confirms practice count updated
  • Nav check: parse nav-links list, confirm no "Tryouts" entry
ISSUE: Missing criteria for sibling files. The blast radius analysis (below) reveals tryout references in staff.html, sponsors.html, success.html, meta tags, and css/style.css. The acceptance criterion "No references to tryouts remain anywhere on the page" scopes to index.html only, but the ticket should explicitly scope or exclude these other files.

Blast Radius

Significant blast radius beyond index.html. Grep for "tryout/Tryout/tryouts/Tryouts" across the repo found references in:
  • staff.html — line 44: nav link index.html#tryouts; lines 149-150: bottom CTA "Sign up for tryouts" with link to index.html#tryouts
  • sponsors.html — line 44: nav link index.html#tryouts
  • success.html — lines 7, 13, 21: meta descriptions reference tryouts; line 45: nav link; lines 57, 84, 100: body content about tryout registration confirmation
  • css/style.css — lines 303-355: tryout-banner CSS rules (dead CSS after banner removal)
  • README.md — line 16: mentions "Stripe Payment Links for tryout registration"
  • CLAUDE.md — line 14: describes index.html as "Landing/tryouts page"
  • Meta tags in index.html itself — lines 7, 12, 20: description/OG/Twitter all say "Sign up for tryouts"
The ticket's acceptance criteria include "OG/meta description updated to remove tryout references" (covers index.html meta tags) and "Nav: Tryouts link removed" (covers index.html nav). But the nav links and CTAs in staff.html, sponsors.html, and success.html are NOT scoped. The success.html page is an entire tryout registration confirmation flow that becomes orphaned.

Recommendation

Two specific issues to resolve before this ticket is READY:
  • Expand file targets to include sibling HTML files. At minimum: remove "Tryouts" nav link from staff.html (line 44) and sponsors.html (line 44); update bottom CTA in staff.html (lines 149-150). Either scope success.html for removal/redirect or explicitly defer it to a follow-up ticket.
  • Add acceptance criterion for site-wide tryout grep. Change "No references to tryouts remain anywhere on the page" to "No references to tryouts remain in any .html file in the repo" — or explicitly list which files are in-scope and which are deferred.
The dead CSS in style.css and stale README/CLAUDE.md references are cosmetic nits that can be deferred, but the nav links and CTAs in sibling pages will be broken anchors pointing to a removed #tryouts section.