pal-e-docs

Review: Init container resource limits + busybox tag pinning

review-283-2026-03-27 Review

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related
Note: ### Type says "Feature" but board labels say type:cleanup. Cleanup is correct — adding resource limits to an existing init container is hardening, not a new feature. Minor body fix recommended.

Traceability

  • [ ] story:X label — missing, but this is foundational cleanup (qa-nit from PR review). Acceptable.
  • [ ] arch:X label — missing. Should be arch:kustomize or arch:k8s-deploy to match sibling board items.
  • [x] Forgejo issue — forgejo_admin/pal-e-deployments#44, open

File Targets

  • [x] overlays/basketball-api/prod/deployment-patch.yaml — verified: line 13 has busybox:1.36 (no digest), init container at lines 11-20 has no resources block. Main container at line 64 has resource limits (pattern to follow).

Repo Placement

OK. Issue filed on forgejo_admin/pal-e-deployments, fix is in pal-e-deployments. Single repo, single overlay.

Dependencies

None. No board items block this work. No in_progress items touch the same file. The init container was introduced in PR #43 (already merged).

Acceptance Criteria

2 AC, both machine-verifiable:
  • Resource requests/limits on init container — agent can grep for the block after edit
  • Busybox digest pin — agent can verify image string format
Test command kubectl kustomize overlays/basketball-api/prod/ is real and currently builds clean. Agent can run it post-change.

Blast Radius

Minimal. busybox only appears in this one file across the entire pal-e-deployments repo. No other overlays use initContainers. No base templates reference busybox. Change is fully isolated to basketball-api prod overlay.

Decomposition

1 file target, 2 acceptance criteria, 1 repo. Well under the 5-minute rule. No decomposition needed.

Recommendation

  • [BODY] Fix Type header: "Feature" → "Task" (this is cleanup/hardening, not a new feature)
  • [LABEL] Add arch:k8s-deploy label to board item (matches sibling cleanup items on this board)