pal-e-docs

Review: Keycloak theme polish — QA nits from PR #130

review-243-2026-03-27 Review

review ready
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type
  • [x] Lineage
  • [x] Repo
  • [x] User Story
  • [x] Context
  • [x] File Targets (present but inaccurate — see below)
  • [x] Acceptance Criteria
  • [x] Test Expectations
  • [x] Constraints
  • [x] Checklist
  • [x] Related

Traceability

  • [ ] story:X label — No user story label on board item #243. This is discovered scope / polish work, so arguably foundational — but the issue does contain a user story ("As a developer maintaining the Westside Keycloak theme..."). Recommend adding a story label for traceability.
  • [ ] arch:X label — No architecture label. Recommend arch:keycloak or arch:identity.
  • [x] Forgejo issue — forgejo_admin/pal-e-platform#131, open, valid URL confirmed.

File Targets

  • [ ] terraform/main.tf — ISSUE: Wrong file path. main.tf is now a root orchestrator that calls modules. The cache flags (--spi-theme-static-max-age=-1, --spi-theme-cache-themes=false) are actually in terraform/modules/keycloak/main.tf at line 101. The ticket must be updated to reflect this.
  • [x] keycloak/themes/westside/login/resources/css/westside.css — verified. All three CSS nits confirmed:

Repo Placement

OK. Both files are in forgejo_admin/pal-e-platform, which matches the issue's repo field. Single-repo fix.

Dependencies

  • Parent PR #130 (Keycloak login theme) is in done on the board (#240).
  • No items currently in in_progress that would block this work.
  • Related item #269 ("Cleanup: Keycloak link nits — DRY, coach role, a11y") is also in todo — different scope (westside-app link cleanup vs. platform CSS polish), no conflict.
  • The westside-app/src/app.css design token file is explicitly marked read-only in the issue — good.

Acceptance Criteria

  • [x] "No off-palette colors" — testable via grep for hex values and cross-referencing design tokens.
  • [x] "Border renders as red top only" — testable via Playwright screenshot.
  • [x] "Font size uses rem units" — testable via grep.
  • [x] "Cache flags documented with TODO or removed" — testable by inspecting the file.
  • Test command cd ~/pal-e-platform/terraform && tofu validate is real and appropriate.
  • Playwright screenshot before/after is appropriate for visual regression.

Blast Radius

  • CSS changes are scoped to the Keycloak login theme only. No other services consume westside.css.
  • The cache flag change is Keycloak-specific. Note that start-dev itself is a dev-mode command — the ticket's constraint correctly acknowledges cache flag removal may be deferred to platform hardening.
  • No other Keycloak themes exist in the repo (westside is the only custom theme).

Decomposition Assessment

2 file targets, 1 repo, 4 acceptance criteria. Well within single-agent scope. No decomposition needed.

Recommendation

Two issues must be fixed before this ticket is READY:
  • Fix file target: Change terraform/main.tf to terraform/modules/keycloak/main.tf (line 101). The root main.tf is a module orchestrator and does not contain Keycloak container args.
  • Add traceability labels: Add story:WS-MAINT (or equivalent maintenance story label) and arch:keycloak to board item #243.