pal-e-docs

Review: Remove #kc-registration display:none from landscaping Keycloak theme

review-1942-2026-07-28 Review

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type — Bug
  • [x] Lineage — Blocker for landscaping-assistant#324
  • [x] Repo — ldraney/pal-e-platform
  • [x] What Broke — detailed CSS rule description
  • [x] Repro Steps — 3 steps
  • [x] Expected Behavior — registration link visible
  • [x] Environment — cluster, theme source, ConfigMap, version
  • [x] File Targets — extra section (not in bug template), acceptable
  • [x] Acceptance Criteria — 3 criteria
  • [x] Related — #324 and validation note

Traceability

  • [x] story:account-email label — Account Email Delivery
  • [x] story note verified — story-landscaping-assistant-account-email exists in pal-e-docs, listed in project-landscaping-assistant user-stories section
  • [x] arch:keycloak label — Keycloak architecture
  • [x] arch note verified — arch-keycloak note exists in pal-e-docs
  • [x] Forgejo issue — ldraney/pal-e-platform#566, open

File Targets

  • [x] keycloak/themes/landscaping/login/resources/css/login.css (pal-e-platform) — verified: #kc-registration { display: none !important; } exists at lines 340-341 exactly as described. Comment block (lines 331-339) confirms this was intentional for App Store v1.0 and says "Re-enable by removing this block when client self-registration is ready for production."

Repo Placement

OK. Issue filed on ldraney/pal-e-platform, which is correct — the CSS is deployed via ConfigMap keycloak-landscaping-theme from terraform modules/keycloak/main.tf.
Note: A development copy exists in ldraney/landscaping-assistant at keycloak-theme/landscaping/login/resources/css/login.css (lines 405-407). The landscaping-assistant repo has uncommitted changes that ADD the same display:none block. The agent implementing this fix should also ensure the landscaping-assistant copy does not retain the block, but pal-e-platform is the deployment source of truth.

Dependencies

  • Blocks: Board item #1927 (landscaping-assistant#324 — "landing page + public registration") is in the validation column. Validation found AC4 FAIL due to this CSS rule.
  • Blocked by: Nothing
  • Dependencies documented in issue Lineage section: yes

Acceptance Criteria

3 AC, all clear and agent-verifiable via browser tools:
  • AC1: element visibility — check via DOM inspection or screenshot
  • AC2: link clickable and navigates — check via browser click
  • AC3: login flow unaffected — verify existing login still works
No missing criteria. For a CSS-only change, browser verification is the appropriate test method.

Blast Radius

  • Other Keycloak themes (paldocs, iss, prediction-assistant) reference #kc-registration for styling but none have display: none — no cross-theme blast radius.
  • The landscaping-assistant repo has uncommitted changes adding the same display:none block — coordinate to ensure those changes do not include the block.

Decomposition Assessment

1 file target in 1 repo. 3 acceptance criteria. Estimated agent work: under 2 minutes (remove CSS block + comment). No decomposition needed.

Recommendation

No action needed. Scope is solid, all traceability verified, file targets confirmed, fits in a single agent pass.