pal-e-docs

Review: Map directions opens in-app sheet instead of native Apple Maps

review-1902-2026-07-25 Review

review ready
Project

Verdict: READY

Re-review. First review returned NEEDS_REFINEMENT with 5 issues. All 5 have been addressed. Full re-review passes.

Prior Issues Resolved

  • [x] File Targets updated to mention both Directions links (line 32 and line 58)
  • [x] Board label corrected to story:property-crud
  • [x] Lineage section added: "Standalone -- discovered during usage session."
  • [x] Environment section added: "iOS turbo-ios wrapper + web browser."
  • [x] Test command changed from rails test to bundle exec rspec

Template Completeness

  • [x] Type -- Bug
  • [x] Lineage -- "Standalone -- discovered during usage session."
  • [x] Repo -- ldraney/landscaping-assistant
  • [x] What Broke -- present as "What happened" (describes webview sheet behavior)
  • [x] Repro Steps -- present as "Steps to reproduce" (4 steps)
  • [x] Expected Behavior -- present
  • [x] Environment -- "iOS turbo-ios wrapper + web browser."
  • [x] Acceptance Criteria -- 3 criteria, reasonable
  • [x] Related -- present
Extra sections present (not in bug template but useful): Investigation notes, File Targets, Test Expectations, Constraints, Checklist.

Traceability

  • [x] story:property-crud label -- verified in project-landscaping-assistant user-stories section ("Add/edit/delete client properties")
  • [x] story note verified -- found in project-landscaping-assistant user-stories table
  • [x] arch:rails-app label -- arch-rails-app note verified in pal-e-docs
  • [x] arch:ios label -- arch-ios note verified in pal-e-docs
  • [x] Forgejo issue -- ldraney/landscaping-assistant#305, open

File Targets

  • [x] app/views/properties/show.html.erb -- verified: file exists. Line 32: Directions link inside feature_enabled?(:address_detection) branch. Line 58: Directions link in else branch. Both match issue description exactly.
  • [x] app/models/property.rb -- verified: maps_url method at line 58, correctly marked as DO NOT TOUCH.
  • [x] turbo-ios path configuration -- correctly noted as "(if it exists)". Option 2 (data-turbo="false") keeps fix entirely in the Rails repo.

Repo Placement

OK. Issue filed on ldraney/landscaping-assistant, fix is in same repo. Option 2 avoids cross-repo work.

Dependencies

No blockers found. Active board items (#1683 next_up: iOS pipeline bug, #1756 todo: multi-tenancy seed data) are unrelated. This ticket is standalone.

Acceptance Criteria

3 ACs -- reasonable scope. Two require manual iOS testing. Regression check covered by bundle exec rspec. Test command is correct.

Blast Radius

Only one other target="_blank" link exists: app/views/property_comments/_comment.html.erb:15 (photo attachment via rails_storage_proxy_path). This is an internal URL -- opening a photo in a modal/sheet is expected turbo-ios behavior. Not affected by this bug. No existing data-turbo attributes in any view templates. Blast radius is limited to the two Directions links in show.html.erb.

Decomposition Assessment

1 file target in 1 repo (2 link instances in the same file). 3 acceptance criteria. Estimated agent work: under 5 minutes (add data: { turbo: false } to two link_to calls). No decomposition needed.

Recommendation

No action needed. All prior issues resolved. Ticket is ready for implementation.