pal-e-docs

Review: Replace favicon with ISS helmet logo

review-1897-2026-07-20 Review

review ready
Project

Verdict: READY

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- Standalone, designed in iss-logo repo
  • [x] Repo -- ldraney/intelligentstaffingsystems
  • [x] User Story -- present (As a site visitor...)
  • [x] Context -- detailed background on logo design and current placeholders
  • [x] File Targets -- 2 modify targets + 1 do-not-touch, clearly scoped
  • [x] Feature Flag -- none (appropriate for static asset swap)
  • [x] Acceptance Criteria -- 4 criteria
  • [x] Test Expectations -- visual verification (appropriate for favicon)
  • [x] Constraints -- 4 constraints covering upscale, SVG quality, transparency, source of truth
  • [x] Checklist -- standard 3 items
  • [x] Related -- present

Traceability

  • [x] story:ui-ux label -- "Design doc + tab architecture established as single source of truth"
  • [x] story note verified -- found in project-iss user-stories section (key: ui-ux, backing: docs/ui-ux.md)
  • [x] arch:frontend label -- frontend component
  • [x] arch note verified -- arch-frontend note exists in pal-e-docs (note: arch-frontend describes prediction-assistant frontend; ISS uses similar Turbo Native + Hotwire stack but has no ISS-specific arch-frontend note. Not a blocker for a favicon swap.)
  • [x] Forgejo issue -- https://forgejo.tail5b443a.ts.net/ldraney/intelligentstaffingsystems/issues/106, open

File Targets

  • [x] public/icon.png -- verified: exists (4.2K), is the placeholder to be replaced
  • [x] public/icon.svg -- verified: exists (122 bytes), confirmed red circle placeholder SVG
  • [x] app/views/layouts/application.html.erb:17-19 -- verified: lines 17-19 contain icon.png, icon.svg, and apple-touch-icon link tags. Correctly listed as do-not-touch.
  • [x] Source: ~/iss-logo.png -- verified: exists (45K, 300x300)
  • [x] Source: ~/iss-logo/logos.html -- verified: exists (11K), contains V1-R2 helmet canvas drawing code

Repo Placement

OK. Issue filed on ldraney/intelligentstaffingsystems, fix targets are in the same repo. Source artwork is in the separate iss-logo workspace (design-only, not deployed).

Dependencies

None. Standalone work. No blocking or blocked items on board-iss. Logo design is finalized in the iss-logo workspace.

Acceptance Criteria

4 visual criteria, all reasonable for a static asset swap. AC #2 (iOS apple-touch-icon) technically requires a device but the link tag already points to /icon.png, so file replacement handles it. Test expectations are visual-only -- appropriate since there is no behavioral logic to unit test.

Blast Radius

Low. Observation: app/views/pwa/manifest.json.erb also references /icon.png (lines 5 and 10) for PWA icons. Not mentioned in the issue, but since the file is replaced in-place at the same path, the PWA manifest will automatically pick up the new icon. No action needed -- this is handled by the in-place replacement strategy.

Decomposition Assessment

No decomposition needed. 2 file targets in 1 repo. 4 acceptance criteria. Estimated agent work well under 5 minutes -- straightforward file copy (PNG) and SVG redraw from existing canvas source.

Recommendation

No action needed.