pal-e-docs

Review: Fix action_mailer default_url_options (still references example.com)

review-1867-2026-07-25 Review

review block
Project

Verdict: BLOCK

Template Completeness

  • [x] Type -- Bug
  • [x] Lineage -- Standalone, discovered during QA review of PR #70
  • [x] Repo -- ldraney/intelligentstaffingsystems
  • [x] What Broke -- described clearly
  • [x] Repro Steps -- 3 steps provided
  • [x] Expected Behavior -- described
  • [x] Environment -- prod, current main
  • [x] Acceptance Criteria -- 3 items
  • [x] Related -- project-iss, PR #70 / #69

Traceability

  • [x] story:project-setup label -- found in project-iss user-stories section
  • [x] arch:rails label -- arch-rails note exists in pal-e-docs
  • [x] Forgejo issue #71 -- open (should be closed as already-fixed)

File Targets

  • [ ] config/environments/production.rb -- ISSUE: The bug no longer exists. Line 60 already reads config.action_mailer.default_url_options = { host: "intelligentstaffingsystems.ai" }. This was fixed by PR #87 which addressed issue #85.

Repo Placement

OK -- issue filed on correct repo.

Dependencies

Issue #85 (board item #1875, column: done) already fixed this bug as part of "fix: CI minitest/mock LoadError + placeholder k8s secrets + action_mailer example.com" via PR #87. This issue is a duplicate of work already completed.

Acceptance Criteria

All three acceptance criteria are already satisfied in the current codebase:
  • [x] action_mailer.default_url_options host set to intelligentstaffingsystems.ai -- confirmed at production.rb line 60
  • [x] No other references to example.com remain in production config -- remaining references are all in comments (lines 22, 66, 83-84), not active code
  • [x] Bug no longer reproduces -- the file already has the correct value

Blast Radius

Grep found additional example.com references, none of which are bugs in this context:
  • app/mailers/application_mailer.rb:2 -- default from: "from@example.com" is a scaffold default "from" address. This is a separate concern (not a URL option) and could warrant its own ticket if mailers are ever activated.
  • config/environments/test.rb:40 -- example.com in test mailer config is standard practice.
  • Test files and fixtures -- standard use of example.com domain for test data.

Decomposition Assessment

Not applicable -- no work to perform. The bug is already fixed.

Recommendation

  • [SCOPE] Close Forgejo issue #71 as already-fixed. The fix shipped in PR #87 (issue #85). Remove board item #1867 from the board or move to done.
  • [SCOPE] Consider filing a separate ticket for app/mailers/application_mailer.rb from@example.com if/when mailers are activated.