Review: Issue #184 -- Worktree Isolation Enforcement Gaps (2026-03-27)
Review: Issue #184 -- Worktree Isolation Enforcement Gaps
Reviewed: 2026-03-27 | Reviewer: Dottie | Verdict: NEEDS_REFINEMENT
Issue:
forgejo_admin/claude-custom#184 -- Feature: Worktree isolation enforcement gaps -- hooks, SOP alignment, cleanup coverageTemplate Compliance
Status: PASS -- All 11 required sections from
template-issue-feature are present.| Section | Present | Notes |
|---|---|---|
| Type | Yes | Feature |
| Lineage | Yes | Standalone with cross-refs to #188 and 3 prior reviews |
| Repo | Yes | forgejo_admin/claude-custom |
| User Story | Yes | As Betty Sue, clear motivation with root cause incident |
| Context | Yes | 5-gap analysis, each verified against source files |
| File Targets | Yes | Modify + Should NOT touch + SOP targets separated |
| Acceptance Criteria | Yes | 6 measurable criteria |
| Test Expectations | Yes | 4 test items |
| Constraints | Yes | 4 constraints including graceful degradation |
| Checklist | Yes | 7 items |
| Related | Yes | 5 cross-references |
File Target Verification
Status: PASS -- All 7 targets verified on disk and in pal-e-docs.
| Target | Exists | Gap Description Accurate |
|---|---|---|
| <code>hooks/cleanup-worktrees.sh</code> | Yes | Yes -- REPO_DIRS has 9 entries, 3 stale names confirmed (pal-e-api, pal-e-sdk, pal-e-mcp on lines 17-19) |
| <code>hooks/check-agent-spawn.sh</code> | Yes | Yes -- validates issue refs only, no freshness check |
| <code>agents/qa.md</code> | Yes | Yes -- no <code>isolation:</code> in frontmatter; schema says <code>true</code> |
| <code>schemas/agent-spawn-requirements.json</code> | Yes | Yes -- QA <code>isolation: true</code> on line 14 |
| <code>CLAUDE.md</code> | Yes | Yes |
| <code>worktree-workflow</code> (SOP) | Yes | Yes -- note exists in pal-e-docs |
| <code>sop-claude-config-development</code> (SOP) | Yes | Yes -- note exists in pal-e-docs |
Decomposition Assessment
Status: NEEDS WORK
7 checklist items across 2 systems (claude-custom code + pal-e-docs SOPs). Per
feedback_three_thing_limit and feedback_five_minute_agent_rule:- Agent 1 (Devy): Items 1-4 -- cleanup-worktrees repo list, freshness check hook, QA isolation reconciliation, CLAUDE.md cross-refs. 4 changes in one repo, tightly coupled. Borderline but acceptable as one PR.
- Agent 2 (Dottie): Items 5-6 -- worktree-workflow SOP update, sop-claude-config-development SOP update. 2 doc changes, well within scope.
- Item 7: Post-merge integration test. Not a standalone agent task.
The issue implicitly documents this split (File Targets separates "Modify" from "SOP updates via pal-e-docs MCP," checklist items 5-6 say "(via Dottie)"). But there is no explicit Decomposition section declaring agent routing.
Dependency Clarity
Status: NEEDS WORK
- Sibling scope (
pal-e-platform#188) and complementary issue (#136) are correctly noted as non-blocking. - Missing: Explicit ordering constraint -- SOP updates (Dottie, items 5-6) should happen AFTER code changes (Devy, items 1-4) merge, so SOPs describe implemented behavior. The issue does not state this.
Refinement Required
Two additions needed before this issue moves to
next_up:- Add explicit Decomposition section -- State: "Devy: items 1-4 (one PR to claude-custom). Dottie: items 5-6 (pal-e-docs MCP updates). Item 7: post-merge validation."
- Add ordering constraint -- State: "Dottie work depends on Devy PR merging first. SOPs must describe the implemented hooks, not the planned hooks."
Verdict
NEEDS_REFINEMENT -- Template-compliant and file targets verified. Decomposition is implicit but not formally declared. Ordering dependency between code and doc work is undocumented. Two additions to the issue body will make this dispatch-ready.