pal-e-docs

Review: App Store rejection: fix privacy declarations in App Store Connect (Guideline 5.1.2(i))

review-1683-2026-07-03-r2 Review

review ready
Project

Verdict: READY

Re-review of board item #1683. Previous review (review-1683-2026-07-03) returned NEEDS_REFINEMENT citing two missing traceability notes. Both have now been created and verified.

Template Completeness

  • [x] Type — Bug
  • [x] Lineage — Standalone, discovered during App Store review of v1.0
  • [x] Repo — ldraney/landscaping-assistant
  • [x] What Broke — Clear description of over-declared privacy data categories
  • [x] Repro Steps — 3 steps to reproduce in App Store Connect
  • [x] Expected Behavior — Accurate mapping of data types to purposes
  • [x] Environment — App Store Connect web UI, review device identified
  • [x] Acceptance Criteria — 3 criteria
  • [x] Related — References rejection doc

Traceability

  • [x] story:app-store-submission label — present on board item
  • [x] story note verified — found in project-landscaping-assistant user-stories section (key=app-store-submission, role=All roles, summary="Submit and maintain iOS App Store listing")
  • [x] arch:ios-pipeline label — present on board item
  • [x] arch note verified — arch-ios-pipeline note exists in pal-e-docs (project: landscaping-assistant, covers Xcode project, Fastlane, App Store Connect, TestFlight, signing)
  • [x] Forgejo issue — ldraney/landscaping-assistant#289, open

File Targets

  • [x] docs/app-store-review/2026-07-02-rejection-v1.0.md — verified: file exists (3.7k), contains full rejection details
  • No code file targets — fix is in App Store Connect web UI, not in the codebase

Repo Placement

OK. Issue filed on ldraney/landscaping-assistant, which is the app this App Store submission belongs to. The fix is a metadata change in App Store Connect (web UI only), but filing on the app's repo is appropriate. No other repos affected.

Dependencies

Three sibling items from the same App Store rejection (all story:app-store-submission):
  • Board #1683 (this item) — Guideline 5.1.2(i) privacy declarations (web UI fix)
  • Board #1684 — Guideline 2.1(a) Keycloak register button error (arch:keycloak, code fix)
  • Board #1685 — Guideline 5.1.1(v) account deletion (arch:rails-app, feature work)
All three must be resolved before App Store resubmission. They are independent of each other — no blocking relationship. No items in in_progress block this ticket. The only todo item (#1403, property detail page) is unrelated.

Acceptance Criteria

3 criteria, all clear and testable. All are manual-only (App Store Connect web UI). An agent cannot verify these programmatically — there is no API for App Store Connect privacy declarations. Acceptable for a web-UI-only metadata fix. A human must verify by inspecting the privacy page after updating.

Blast Radius

Minimal. No code changes involved. The fix only changes metadata in Apple's App Store Connect portal. No downstream code consumers, no API changes, no database changes. Privacy declarations are specific to this app.

Decomposition Assessment

No decomposition needed. 0 code file targets, 3 acceptance criteria, estimated completion time well under 5 minutes. Manual web UI task.

Recommendation

No action needed. Previous NEEDS_REFINEMENT issues resolved:
  • [RESOLVED] story note "app-store-submission" created on project-landscaping-assistant user-stories section
  • [RESOLVED] architecture note arch-ios-pipeline created in pal-e-docs