pal-e-docs

Review: Add Tailscale funnel ingress + rename westside-ror overlay to westside-basketball (r3)

review-1631-2026-06-27-r3 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Round 3 review. The dev overlay scope and reference counts are now accurate (verified: 5+4+4+6 = 19 stale references across 4 files). However, the issue still contains a critical factual error about the prod overlay, and the ACs are incomplete as a result.

Template Completeness

  • [x] Type — Bug
  • [x] Lineage — sub-ticket of #220, discovered during sprint 5 validation
  • [x] Repo — ldraney/pal-e-deployments
  • [x] What Broke — present, detailed
  • [x] Repro Steps — present, 3 steps
  • [x] Expected Behavior — present
  • [x] Environment — present with file listings
  • [x] Acceptance Criteria — present, 7 items
  • [x] Related — present with prior reviews

Traceability

  • [x] story:WS-S1 — "As superadmin, I want to deploy platform changes via IaC so that infrastructure is reproducible and auditable"
  • [x] story note verified — found in project-westside-basketball user-stories section (Superadmin list)
  • [x] arch:iac label — infrastructure-as-code component
  • [ ] arch note MISSING — [SCOPE] No arch-iac note found in pal-e-docs. Acceptable for now: IaC is a cross-cutting concern, not a discrete component. Low priority.
  • [x] Forgejo issue — ldraney/pal-e-deployments#221, open

File Targets

  • [x] overlays/westside-ror/dev/deployment.yaml — verified: 5 stale westside-ror references, hostPath at line 47 confirmed
  • [x] overlays/westside-ror/dev/service.yaml — verified: 4 stale references
  • [x] overlays/westside-ror/dev/ingress.yaml — verified: 4 stale references
  • [x] overlays/westside-ror/README.md — verified: 6 stale references
  • [ ] overlays/westside-ror/prod/kustomization.yaml — ISSUE: issue claims "already reference westside-basketball correctly" and lists as "Clean files (no action needed)." In reality this file has 9 stale westside-ror references and 0 westside-basketball references.
  • [ ] overlays/westside-ror/prod/deployment-patch.yaml — ISSUE: issue claims "Clean files (no action needed)." In reality this file has 1 stale westside-ror reference (hostPath line 58: /home/ldraney/westside-ror) and 0 westside-basketball references.

Repo Placement

Correct. Issue filed on pal-e-deployments, fix is in pal-e-deployments overlay files.

Dependencies

  • Parent issue: pal-e-deployments#220 (decomposed parent)
  • Sibling: board item #1632 — "Update NetworkPolicy: replace westside-ror with westside-basketball" (todo, sprint:6)
  • Sibling: board item #1633 — "Drop stale basketball DB role + update Keycloak westside-ror references" (todo, sprint:6)
  • Predecessor: pal-e-deployments#219 — namespace hotfix (merged)
  • No blockers identified. This ticket can proceed independently.

Acceptance Criteria Assessment

  • [x] AC1: "Overlay directory renamed from westside-ror to westside-basketball" — clear, verifiable (git mv)
  • [x] AC2: "Dev overlay: all resource names, labels, and selectors updated" — clear, verifiable (grep)
  • [x] AC3: "Dev overlay: deployment.yaml hostPath updated (line 47)" — verified line 47 is correct
  • [x] AC4: "Tailscale funnel ingress resource added to prod kustomization" — correct, prod kustomization has no ingress/funnel resources currently
  • [x] AC5: "README.md updated to reference westside-basketball" — clear, verifiable
  • [ ] AC6: "ArgoCD sync succeeds with renamed overlay" — not agent-verifiable post-merge without cluster access, but reasonable as a manual validation step
  • [ ] AC7: "No stale westside-ror references remain in this repo" — ISSUE: contradicts the "prod is clean" claim in the body. Also, 10 additional westside-ror references exist outside the overlay (docs/overlay-structure.md, docs/overlay-inventory.md, README.md, basketball-api/README.md, westsidekingsandqueens/README.md, westsidekingsandqueens/prod/kustomization.yaml, dev-tunnel/README.md). Either scope AC7 to the overlay directory only, or add prod and repo-wide docs to the file targets.
  • [ ] MISSING AC: prod overlay kustomization.yaml — 9 stale references need renaming
  • [ ] MISSING AC: prod overlay deployment-patch.yaml — hostPath at line 58 needs renaming

Blast Radius

10 westside-ror references exist outside overlays/westside-ror/:
  • docs/overlay-structure.md (1 reference)
  • docs/overlay-inventory.md (2 references)
  • README.md (2 references)
  • overlays/basketball-api/README.md (1 reference)
  • overlays/westsidekingsandqueens/README.md (1 reference)
  • overlays/westsidekingsandqueens/prod/kustomization.yaml (1 reference — comment)
  • overlays/dev-tunnel/README.md (2 references — current target URL)
The dev-tunnel overlay references westside-ror.westside-ror.svc.cluster.local as its current target. After the rename, this will break unless updated. Either add to scope or document as known follow-up.

Decomposition Assessment

3 file targets (dev overlay) + 2 prod files + 1 README + directory rename = 6 files across 1 repo. 7+ ACs (after adding missing prod ACs). Estimated agent work: 3-4 minutes. Borderline but single-pass feasible. No decomposition needed.

Recommendations

  • [BODY] Remove false claim: "The prod overlay files (kustomization.yaml, deployment-patch.yaml) already reference westside-basketball correctly" — prod has 10 stale westside-ror references (9 in kustomization.yaml, 1 hostPath in deployment-patch.yaml)
  • [BODY] Remove false "Clean files" listing: "Clean files (no action needed): overlays/westside-ror/prod/kustomization.yaml, overlays/westside-ror/prod/deployment-patch.yaml" — both need renaming
  • [BODY] Update total count: from "19 stale references across 4 files" to "29 stale references across 6 files" (19 dev+README + 10 prod)
  • [BODY] Add AC: "Prod overlay: all resource names, labels, selectors, comments updated to westside-basketball in kustomization.yaml (9 references) and deployment-patch.yaml hostPath (line 58)"
  • [BODY] Scope AC7: either narrow to "No stale westside-ror references remain in the westside-basketball overlay directory" or expand file targets to include repo-wide docs and sibling overlays (10 additional references). Recommend narrowing — repo-wide doc updates are a separate cleanup.
  • [BODY] Add dev-tunnel/README.md to Related section as a known follow-up (its service URL will break after rename)