pal-e-docs

Review: Add Tailscale funnel ingress + rename westside-ror overlay to westside-basketball

review-1631-2026-06-27 Review

review needs-refinement
Project

Verdict: NEEDS_REFINEMENT

Template Completeness

  • [x] Type — Bug
  • [x] Lineage — Sub-ticket of #220, discovered during sprint 5 validation
  • [x] Repo — ldraney/pal-e-deployments
  • [x] What Broke — stale westside-ror references, missing funnel ingress in prod
  • [x] Repro Steps — 3 concrete steps with grep command
  • [x] Expected Behavior — 5 bullet points covering rename + funnel + dev + westsidekingsandqueens
  • [x] Environment — prod, westside-basketball namespace
  • [x] Acceptance Criteria — 8 checkboxes
  • [x] Related — parent issue, predecessor, review note, project page

Traceability

  • [x] story:WS-S1 label — "As superadmin, I want to deploy platform changes via IaC so that infrastructure is reproducible and auditable"
  • [x] story note verified — found in project-westside-basketball user-stories section (Superadmin list, first entry)
  • [x] arch:iac label — infrastructure-as-code component
  • [ ] arch note MISSING — [SCOPE] Create architecture note arch-iac for the IaC component
  • [x] Forgejo issue — ldraney/pal-e-deployments#221, open

File Targets

  • [x] overlays/westside-ror/prod/kustomization.yaml — verified: 9 stale westside-ror references (6 env var patches, comment, service rename, deployment rename)
  • [x] overlays/westside-ror/prod/deployment-patch.yaml — verified: 1 stale hostPath reference (/home/ldraney/westside-ror on line 58)
  • [x] overlays/westside-ror/dev/deployment.yaml — verified: 5 stale references (name, namespace, labels, hostPath)
  • [x] overlays/westside-ror/dev/service.yaml — verified: 4 stale references (name, namespace, labels, selector)
  • [x] overlays/westside-ror/dev/ingress.yaml — verified: 4 stale references (name, namespace, backend service, TLS host)
  • [x] overlays/westside-ror/dev/kustomization.yaml — verified: 0 stale references (just resource list)
  • [x] overlays/westsidekingsandqueens/prod/kustomization.yaml — verified: line 6 has stale comment "westside-ror namespace"
  • [ ] overlays/westside-ror/README.md — ISSUE: [BODY] Not mentioned in issue body but has 6 stale westside-ror references. Should be included in scope or deleted during rename.
Total stale references: 29 across 7 files (prod: 10, dev: 13, westsidekingsandqueens: 1, README: 6). Issue claims "10+" which is accurate for prod but undercounts the total.

Repo Placement

OK. Issue filed on pal-e-deployments, all affected files are in pal-e-deployments. Single-repo change.

Dependencies

  • Parent issue #220 (board item 1630) — decomposed, in backlog. This is sub-ticket 1 of 4.
  • Sibling sub-tickets in backlog: #1632 (NetworkPolicy update, 1pt), #1633 (drop stale DB role, 2pt), #1634 (CI fix, 1pt)
  • Predecessor #219 (namespace hotfix) — already merged
  • No blocking dependencies — this ticket can proceed independently of siblings

Acceptance Criteria

8 ACs listed. All are verifiable by an agent:
  • ACs 1-6: mechanical rename + file additions, verifiable via grep and file existence checks
  • AC 7 (ArgoCD sync): requires cluster access, may not be automatable in agent pass — but reasonable as a post-merge validation criterion
  • AC 8 (no stale references): verifiable via grep -r westside-ror
AC count (8) exceeds the 5-AC decomposition threshold on paper. However, ACs 1-6 are a single coherent rename operation (one git mv + find-replace), not 6 independent tasks. No decomposition needed.

Blast Radius

  • The overlays/westside-ror/README.md has 6 stale references not mentioned in the issue. An agent doing the rename would likely miss updating it or removing it.
  • No other overlays reference westside-ror — blast radius is contained to the westside-ror/ directory and one comment in westsidekingsandqueens/.
  • The dev overlay ingress already has the correct Tailscale funnel pattern — the prod overlay just needs an equivalent ingress resource added.

Decomposition Assessment

8 ACs across 1 repo, ~7 file targets. ACs 1-6 are a single atomic rename. Estimated agent work: ~3 minutes (git mv + sed + add ingress resource). No decomposition needed despite AC count exceeding threshold.

Recommendation

  • [BODY] Add overlays/westside-ror/README.md to file targets or add AC: "README.md updated or removed during rename"
  • [SCOPE] Create architecture note arch-iac for the IaC component (this is a cross-cutting concern, not specific to this ticket — can be deferred)