Review: Define sprint done criteria: all items validated in production

review-1617-2026-06-26 Review

review needs-refinement

Project

Template Completeness

[x] Type — Feature
[x] Lineage — present
[x] Repo — ldraney/claude-custom
[x] User Story — present
[x] Context — present, well-written with concrete Sprint 5 failure evidence
[x] File Targets — present (1 file)
[x] Feature Flag — None (appropriate for memory file update)
[x] Acceptance Criteria — present (5 items)
[x] Test Expectations — present (manual verification)
[x] Constraints — present (2 constraints)
[x] Checklist — present
[x] Related — present

Traceability

[ ] story:sprint-planning label — MISMATCH: The project page (project-claude-custom) has a sprint-orchestration user story but no sprint-planning story. The board item uses story:sprint-planning which has no backing entry. [SCOPE] Either create a sprint-planning user story entry on project-claude-custom, or change the label to story:sprint-orchestration (sprint done criteria is arguably part of sprint orchestration).
[ ] arch:memory label — MISSING NOTE: No arch-memory architecture note found in pal-e-docs. [SCOPE] Create architecture note arch-memory for the memory component, or change to an existing arch label that fits.
[x] Forgejo issue — #290, open, valid URL

File Targets

[x] ~/.claude/projects/-home-ldraney-claude-custom/memory/feedback_sprint-philosophy.md — verified: file exists (28 lines). Currently defines what a sprint IS (parallel, scope-based, no internal deps) but has no Definition of Done section. Correct target for the change.
[ ] MEMORY.md — ISSUE: AC #5 says "Update MEMORY.md sprint status entries to use 'IN VALIDATION' instead of 'DONE'" but MEMORY.md is not listed in File Targets. Verified that MEMORY.md exists and contains sprint entries marked "DONE" on lines 46, 56. [BODY] Add MEMORY.md to File Targets section.

Repo Placement

OK. Issue filed on ldraney/claude-custom, targets memory files in ~/.claude/projects/-home-ldraney-claude-custom/memory/. Correct repo.

Dependencies

No blocking dependencies found. Board item #1617 is independent. Related items on the board:

#280 (Sprint SOP — codify cross-project wave concept) is in_progress — related but not blocking. The sprint SOP defines sprint mechanics; this ticket defines sprint done criteria. They are complementary but independent.
#275 (Dictionary definitions) is in_progress — could define "done" but this ticket is specifically about sprint done criteria in memory, not dictionary.

No undocumented dependencies.

Acceptance Criteria

5 ACs — right at the decomposition threshold but appropriate for a 1-point memory file update. All are verifiable:

AC 1-3: Can be verified by reading the updated feedback_sprint-philosophy.md for the new section and corollaries.
AC 4: Can be verified by checking for cross-reference to sop-board-workflow.
AC 5: Can be verified by reading MEMORY.md sprint status entries for correct terminology.

All ACs are agent-verifiable. No missing criteria detected.

Blast Radius

Low. Changes are confined to memory files which are session-context only. No hooks, scripts, or code reference these files programmatically. The sprint done definition may influence future sprint status tracking in MEMORY.md, but that is the stated intent. No sibling services affected.

Decomposition Assessment

1 file target (+1 missing from File Targets), 5 ACs, 1 repo. Estimated agent work well under 5 minutes — this is a documentation/memory update. No decomposition needed.

Recommendation

[BODY] Add MEMORY.md to File Targets: ~/.claude/projects/-home-ldraney-claude-custom/memory/MEMORY.md — update sprint status entries from "DONE" to "IN VALIDATION" where applicable.
[LABEL] Change story:sprint-planning to story:sprint-orchestration on board item #1617 (sprint-orchestration story already exists on project-claude-custom; sprint-planning does not).
[SCOPE] Create architecture note arch-memory for the memory component in pal-e-docs, OR change the arch:memory label to an existing arch component that fits.