Review: docs: update docs/ for consolidation and codify sprint philosophy (round 2)

Verdict: APPROVED

Template Completeness

• [x] Type -- Feature
• [x] Lineage -- present, references PR #60 as upstream
• [x] Repo -- ldraney/paldocs
• [x] User Story -- present
• [x] Context -- thorough, explains both stale docs and sprint philosophy with DORA rationale
• [x] File Targets -- present, all corrected from round 1
• [x] Feature Flag -- none, docs-only, appropriate
• [x] Acceptance Criteria -- 6 criteria, all clear and verifiable
• [x] Test Expectations -- 2 items, appropriate for docs
• [x] Constraints -- present
• [x] Checklist -- present, matches all file targets
• [x] Related -- present, includes project page, arch note, story, upstream/downstream

Traceability

• [x] story:sprint-orchestration label -- present on board item
• [x] story note verified -- story-paldocs-sprint-orchestration found in project-paldocs user-stories section
• [x] arch:docs label -- present on board item
• [ ] arch note MISSING -- [SCOPE] No arch-docs note found in pal-e-docs. Create architecture note arch-docs for the docs component. (Carried from round 1 -- this is external to the issue body and does not block the ticket.)
• [x] Forgejo issue -- ldraney/paldocs#67, open

File Targets

• [x] README.md -- verified: exists at /home/ldraney/paldocs/README.md. Stale references confirmed at lines 3, 12, 19, 20, 42, 79. Line 79 has "No Rails-managed migrations" claim. Line 20 references pal-e-docs FastAPI as coexisting.
• [x] docs/data-model.md -- verified: exists. Stale references at lines 3, 134-137 (schema managed externally, DDL managed by FastAPI). CORRECTED from round 1 (was docs/shared-database.md).
• [x] docs/infrastructure.md -- verified: exists. Stale references at lines 61, 64 (external shared database managed by pal-e-docs FastAPI). CORRECTED from round 1 (was docs/architecture.md).
• [x] docs/auth-visibility-architecture.md -- verified: exists. Stale Alembic references at lines 58, 126. Additional pal-e-docs references throughout (lines 7, 19, 22, 24, 40, 49, 53, 55, 67, etc.). ADDED in round 2 per round 1 recommendation.
• [x] docs/sprint-philosophy.md -- verified: does NOT exist yet (expected -- ticket says NEW).

Round 1 Fixes Verified

• [x] [BODY] docs/shared-database.md corrected to docs/data-model.md -- verified in File Targets and AC2
• [x] [BODY] docs/architecture.md corrected to docs/infrastructure.md -- verified in File Targets and AC3
• [x] [BODY] AC2 updated to reference docs/data-model.md -- verified
• [x] [BODY] AC3 updated to reference docs/infrastructure.md -- verified
• [x] [BODY] docs/auth-visibility-architecture.md added to File Targets -- verified, with dedicated AC4
• [ ] [SCOPE] Create arch-docs note -- still outstanding (does not block ticket, see below)

Repo Placement

Dependencies

• Upstream (completed): paldocs#49 (schema ownership transfer) -- merged as PR #60. This is what created the stale docs.
• Downstream: paldocs#50 (sprint schema, in next_up) -- the sprint philosophy doc should inform #50's design. No hard blocker, but logical ordering is correct.
• No blockers from in_progress items. No items currently in_progress on board-paldocs.

Acceptance Criteria

• AC1: grep README for pal-e-api DDL references -- verifiable
• AC2: grep data-model.md for Alembic references -- verifiable
• AC3: grep infrastructure.md for stale ownership claims -- verifiable
• AC4: grep auth-visibility-architecture.md for stale pal-e-docs/Alembic references -- verifiable
• AC5: file existence check + content verification for sprint-philosophy.md -- verifiable
• AC6: recursive grep across all docs for stale references -- verifiable (catch-all)

Blast Radius

• README.md -- 6 lines with stale references
• docs/data-model.md -- 3 lines (lines 3, 134, 137)
• docs/infrastructure.md -- 2 lines (lines 61, 64)
• docs/auth-visibility-architecture.md -- 2 explicit Alembic lines (58, 126) plus many pal-e-docs references throughout. Note: many pal-e-docs references in this file are about the Keycloak realm name (pal-e-docs realm), which is still valid and should NOT be removed. The agent must distinguish between stale schema ownership references and valid realm name references.

Decomposition Assessment

Recommendation

• [SCOPE] Create architecture note arch-docs in pal-e-docs for the docs component. (Carried from round 1 -- does not block ticket advancement. Can be done in parallel or after.)