pal-e-docs

Review: Sprint planning UI -- controller, views, routes for wave planner

review-1566-2026-06-22-r2 Review

review ready
Project

Verdict: READY

Round 2 re-review. Round 1 flagged arch-rails-views as missing. Confirmed it exists (id 1839, note_type architecture, status active). All prior checks still pass. Ticket is ready for todo.

Template Completeness

  • [x] Type -- Feature
  • [x] Lineage -- depends on paldocs#50
  • [x] Repo -- ldraney/paldocs
  • [x] User Story -- well-formed As/Want/So-that
  • [x] Context -- explains sprint workflow, relationship to #50
  • [x] File Targets -- 6 files to create/modify, 3 exclusions
  • [x] Feature Flag -- none (correct, new routes only)
  • [x] Acceptance Criteria -- 6 criteria, all agent-verifiable
  • [x] Test Expectations -- 4 tests + run command
  • [x] Constraints -- dependency, Hotwire pattern, functional-first
  • [x] Checklist -- present
  • [x] Related -- project, story, arch note, upstream/downstream

Traceability

  • [x] story:sprint-orchestration label -- present on board item
  • [x] story note verified -- story-paldocs-sprint-orchestration exists in pal-e-docs (id 2093) and is listed in project-paldocs user-stories section
  • [x] arch:rails-views label -- present on board item
  • [x] arch note verified -- arch-rails-views exists in pal-e-docs (id 1839, note_type architecture, active). Round 1 incorrectly flagged this as missing.
  • [x] Forgejo issue -- ldraney/paldocs#56, open

File Targets

  • [x] app/controllers/sprint_planning_controller.rb -- does not exist yet (correct, new file to create)
  • [x] app/views/sprint_planning/index.html.erb -- does not exist yet (correct, new file)
  • [x] app/views/sprint_planning/show.html.erb -- does not exist yet (correct, new file)
  • [x] app/views/sprint_planning/_wave.html.erb -- does not exist yet (correct, new partial)
  • [x] config/routes.rb -- exists, verified. Currently has resources for projects, notes, boards, board_items. Sprint planning routes would be added here.
  • [x] app/views/layouts/ -- exists, contains application.html.erb. Navigation currently has only brand link. Sprint planning nav link would go here.
  • [x] Exclusions verified -- db/migrate/, app/models/, db/structure.sql correctly excluded (belong to paldocs#50)

Repo Placement

OK. Issue filed on ldraney/paldocs, all file targets are in the paldocs repo. Single-repo scope.

Dependencies

  • Depends on paldocs#50 (Sprint schema -- migrations + models). Board item #1560, currently in todo column. This ticket cannot start until #50 merges (needs Sprint, SprintProject models and board_items.sprint_id/wave_number columns).
  • paldocs#50 itself may depend on paldocs#49 (Schema ownership transfer, board item #1559, in_progress). Dependency chain is documented and logical.
  • No other board items block this ticket.

Acceptance Criteria

All 6 criteria are agent-verifiable: navigation link presence, sprint CRUD, board item display, side-by-side view, wave staging with sprint_id/wave_number, wave grouping with points. Test commands are real (bundle exec rspec). No missing criteria for the stated scope.

Blast Radius

Low. This ticket adds new routes and views only. No modification to existing controllers or views except adding a nav link to the layout. Existing board/project views are untouched. The new controller follows the same pattern as BoardsController (Hotwire, turbo frames, stimulus controllers).

Decomposition Assessment

6 file targets in 1 repo. 6 acceptance criteria. Estimated agent work under 5 minutes -- straightforward Rails controller + ERB views following established patterns. No decomposition needed.

Recommendation

No action needed. Ticket is ready for todo.