Review: Schema ownership transfer -- pg_dump to Rails structure.sql + first migration (re-review)

Verdict: APPROVED

Previous Issues -- Resolution

• [x] Test command fixed: bundle exec rspec (was rails test)
• [x] config/application.rb comment: now called out in File Targets ("update ownership comment (lines 42-44)") and in Context section
• [x] story:consolidation note: story-paldocs-consolidation exists (id 2092), listed on project-paldocs user-stories section
• [x] arch-rails-db note: arch-rails-db exists (id 1840), full architecture template with ER diagram, components table, key decisions

Template Completeness

• [x] Type -- Feature
• [x] Lineage -- standalone, supersedes pal-e-api#282
• [x] Repo -- ldraney/paldocs
• [x] User Story -- present and clear
• [x] Context -- good background on ownership transfer rationale, includes application.rb comment update note
• [x] File Targets -- 5 modify/create targets, 2 exclusions, application.rb comment explicitly targeted
• [x] Feature Flag -- none, justified (default status preserves behavior)
• [x] Acceptance Criteria -- 6 items
• [x] Test Expectations -- correct: bundle exec rspec
• [x] Constraints -- 4 items, well-scoped
• [x] Checklist -- present, includes application.rb comment update
• [x] Related -- present, references story and arch notes

Traceability

• [x] story:consolidation label -- story-paldocs-consolidation note exists, listed on project-paldocs user-stories section
• [x] story note verified -- found in project-paldocs user-stories section (4th entry)
• [x] arch:rails-db label -- arch-rails-db note exists with ER diagram and component table
• [x] arch note verified -- arch-rails-db note (id 1840) exists in pal-e-docs, tags: architecture, active
• [x] Forgejo issue -- https://forgejo.tail5b443a.ts.net/ldraney/paldocs/issues/49, open

File Targets

• [x] db/structure.sql -- does not exist yet (correct, will be created via pg_dump import)
• [x] config/application.rb -- verified: exists, line 46 currently config.active_record.schema_format = :ruby, needs change to :sql. Lines 42-44 contain the ownership comment that must be updated. Both called out in issue.
• [x] Gemfile -- verified: exists, no neighbor gem present currently
• [x] db/migrate/XXXXXX_add_status_to_projects.rb -- will be created (correct, 2 existing migrations in db/migrate/)
• [x] app/models/project.rb -- verified: exists, no status scopes currently (8 lines, basic model with has_many/belongs_to)

Repo Placement

Dependencies

• No blocking dependencies on the board. This is wave:0 -- it is the foundation that wave:1 (#1560 sprint planning UI), wave:2 (#1561 API endpoints, #1562 embedding pipeline), wave:3 (#1564 MCP server), and wave:4 (#1565 migration) depend on.
• Downstream wave ordering correctly captured in issue Related section.
• Requires access to production database for pg_dump. Constraint documented in issue.

Acceptance Criteria

• [x] AC 1-5 are verifiable by an agent (run commands, check output)
• [x] AC 6 ("When I check pal-e-docs Alembic, then no new migrations are being generated there") -- coordination concern, acceptable as manual check
• [x] Test command is bundle exec rspec -- matches project test framework (rspec-rails in Gemfile, spec/ directory, .rspec config)

Blast Radius

• pal-e-docs (FastAPI) -- continues to read/write the same database. Adding status VARCHAR(50) DEFAULT 'active' column is additive and non-breaking.
• pal-e-mcp -- proxies to pal-e-docs API, unaffected by schema additions.
• Embedding worker -- writes to blocks.embedding column, unaffected by projects table changes.
• production.rb -- also sets dump_schema_after_migration = false (line 57). Agent should be aware of this but the issue's constraint scope handles it.
• schema.rb -- does not exist currently (dump disabled). Switching to :sql format is clean.

Decomposition Assessment

Recommendation