Review: Properties tab: add sort toggle (alphabetical / proximity)

Verdict: APPROVED

Template Completeness

• [x] Type — Feature
• [x] Lineage — Standalone, follow-up to PR #207
• [x] Repo — ldraney/landscaping-assistant
• [x] User Story — proper As/I want/So that format
• [x] Context — explains PR #207 replaced alphabetical with proximity-only, motivates toggle
• [x] File Targets — 4 modify, 2 do-not-touch
• [x] Feature Flag — "none" (UI sort toggle, not new workflow — acceptable)
• [x] Acceptance Criteria — 5 criteria
• [x] Test Expectations — 3 expectations with run command
• [x] Constraints — 3 constraints (no Tailwind, no cookies, preserve filter controller)
• [x] Checklist — present
• [x] Related — present

Traceability

• [x] story:property-crud label — present on board item
• [x] story note verified — "property-crud" found in project-landscaping-assistant user-stories table ("Add/edit/delete client properties", success metric: "Full CRUD with search and filter")
• [x] arch:rails-app label — present on board item
• [x] arch note verified — arch-rails-app note exists in pal-e-docs (active)
• [x] Forgejo issue — ldraney/landscaping-assistant#225, state: open

File Targets

• [x] app/controllers/properties_controller.rb — verified: line 13 has @properties = Property.by_proximity(property_scope.includes(:services)), the exact line needing conditional sort logic
• [x] app/views/properties/manage.html.erb — verified: exists, has filter chips area (service-filters div) as a natural home for the sort toggle
• [x] app/assets/stylesheets/application.css — verified: existing CSS patterns (filter-chip, btn-toggle, toggle-switch) provide reusable patterns
• [x] spec/requests/properties_spec.rb — verified: existing tests for GET /properties/manage with sort ordering tests at lines 22 and 44
• [x] app/models/property.rb (do-not-touch) — verified: by_proximity class method exists at line 26, no model changes needed
• [x] app/controllers/weeks_controller.rb (do-not-touch) — verified: uses by_proximity at line 10, correctly excluded as separate concern

Repo Placement

Dependencies

Acceptance Criteria

• AC1 (alphabetical default) — testable via request spec checking order
• AC2 (visible toggle) — testable via response body inspection
• AC3 (URL query param) — testable via ?sort=proximity param
• AC4 (uses existing by_proximity) — testable by verifying sort order matches model method
• AC5 (filters still work) — testable via request spec with combined params

Blast Radius

• weeks_controller.rb line 10 also uses Property.by_proximity — explicitly excluded from scope, correct.
• days_controller.rb line 16 uses order(:client_name) for alphabetical — serves as reference pattern for the default sort.
• work_queue_items_controller.rb line 358 uses Arel.sql("LOWER(client_name)") — matches AC #1's "case-insensitive" requirement, serves as reference.
• No downstream consumers affected — UI-only change on Properties manage view.

Decomposition Assessment

Recommendation