Review: Integration tests for pkg/godaddy/ client

Verdict: NEEDS_REFINEMENT

Template Completeness

• [x] Type -- Feature
• [x] Lineage -- present (but contains wrong dependency reference)
• [x] Repo -- ldraney/godaddy-tofu
• [x] User Story -- present
• [x] Context -- present, good background
• [x] File Targets -- present, 3 files listed
• [x] Feature Flag -- present (None)
• [x] Acceptance Criteria -- present, 5 items
• [x] Test Expectations -- present, 3 items
• [x] Constraints -- present, 4 items
• [x] Checklist -- present
• [x] Related -- present

Traceability

• [x] story:dns-iac label -- present on board item
• [x] story note reference -- dns-iac entry exists in project-godaddy-tofu user-stories table (Key: dns-iac, links to story-godaddy-tofu-dns-iac)
• [ ] story note MISSING -- story-godaddy-tofu-dns-iac note does not exist in pal-e-docs (search returned 0 results). The project page links to it but the note was never created. [SCOPE] Create story note story-godaddy-tofu-dns-iac.
• [x] arch:godaddy-tofu label -- present on board item
• [ ] arch note MISSING -- No arch-godaddy-tofu note found in pal-e-docs. [SCOPE] Create architecture note arch-godaddy-tofu.
• [x] Forgejo issue -- ldraney/godaddy-tofu#4, state: open

File Targets

• [x] pkg/godaddy/client_test.go -- does not yet exist (to be created). Client code exists in HEAD at pkg/godaddy/client.go. Verified: NewClient(), WithBaseURL(), WithHTTPClient() options pattern is available for test setup.
• [x] pkg/godaddy/dns_test.go -- does not yet exist (to be created). DNS methods verified in HEAD:
• [x] pkg/godaddy/domains_test.go -- does not yet exist (to be created). Domain methods verified in HEAD:

Repo Placement

Dependencies

• [BODY] Wrong dependency reference -- Issue says "Depends on #2" but #2 is the docs foundation PR. The Go scaffold that created pkg/godaddy/ is issue #3 / PR #5. Should say "Depends on #3".
• #3 (Go scaffold) is in done column on the board -- dependency is satisfied.
• Issue #6 relationship -- Issue #6 (QA nits: DomainID float64->int64, io.ReadAll size limit, url variable naming) is on the board in backlog (item #1454, 1 point). These nits affect the code that #4's tests will exercise:

Acceptance Criteria

• [x] "go test ./pkg/godaddy/ -v passes" -- verifiable by running command
• [x] "DNS tests create, read, and delete a test record without leaving state" -- verifiable by test teardown logic
• [x] "Domain tests read existing domain data" -- verifiable
• [x] "Tests skip gracefully when credentials are not set" -- verifiable by running without env vars
• [x] "Tests handle 429 rate limiting with backoff" -- verifiable but the client has no retry/backoff logic. Tests cannot handle 429 if the client doesn't. Either the test must implement its own retry wrapper, or this AC implies adding retry logic to the client (scope creep beyond "integration tests").

Blast Radius

Decomposition Assessment

Recommendations

• [BODY] Fix dependency reference: "Depends on #2" should be "Depends on #3" (the Go scaffold issue).
• [BODY] Fix test name TestAddAndDeleteRecord to reflect that the actual method is AddRecords (plural, takes a slice) -- suggest TestAddAndDeleteRecords.
• [BODY] Address #6 relationship: add note that #6 (QA nits) should land first to avoid DomainID type churn in domain tests. Or explicitly state tests should be written against the post-#6 struct.
• [BODY] Clarify AC for 429 handling: the client has no retry logic. Either (a) descope the 429 AC from this ticket and create a separate ticket for client retry logic, or (b) expand scope to include retry in the client. Current scope is ambiguous.
• [BODY] Consider adding test coverage for ReplaceAllRecords and ReplaceRecordsByType methods (2 of 6 DNS methods are untested by this plan).
• [SCOPE] Create story note story-godaddy-tofu-dns-iac in pal-e-docs (referenced from project page but does not exist).
• [SCOPE] Create architecture note arch-godaddy-tofu in pal-e-docs (board item has arch:godaddy-tofu label but no backing note).